Applied patch from Philip Blundell <pb@nexus.co.uk>: Make address variables

unsigned to avoid problems when disassembling code at high-bit-set addresses.

diff --git a/binutils/ChangeLog b/binutils/ChangeLog
index 06ad27f1e44acafd50fed04b7ad2648acc45660d..bdc342000462a0f2009fb8c962725c706baedfe0 100644 (file)
--- a/binutils/ChangeLog
+++ b/binutils/ChangeLog
@@ -1,3 +1,9 @@
+Tue Oct 27 14:39:00 1998  Nick Clifton  <nickc@cygnus.com>
+
+       * objdump.c (disassemble_bytes): Applied this patch from Philip
+       Blundell <pb@nexus.co.uk>:  Make address variables unsigned to
+       avoid problems when disassembling code at high-bit-set addresses. 
+
 Mon Oct 26 14:07:59 1998  Mumit Khan  <khan@xraylith.wisc.edu>
         
         * dllwrap.c (strhash): New function.

diff --git a/binutils/objdump.c b/binutils/objdump.c
index ececdef6e9188ec90238e21600f062d77f102482..ec7f2efe5a8f2701f1f36e20d9cb392094d89f25 100644 (file)
--- a/binutils/objdump.c
+++ b/binutils/objdump.c
@@ -178,8 +178,8 @@ show_line PARAMS ((bfd *, asection *, bfd_vma));
 
 static void
 disassemble_bytes PARAMS ((struct disassemble_info *, disassembler_ftype,
-                          boolean, bfd_byte *, long, long, arelent ***,
-                          arelent **));
+                          boolean, bfd_byte *, unsigned long, unsigned long,
+                          arelent ***, arelent **));
 
 static void
 disassemble_data PARAMS ((bfd *));
@@ -376,7 +376,7 @@ slurp_symtab (abfd)
 
   if (!(bfd_get_file_flags (abfd) & HAS_SYMS))
     {
-      printf (_("No symbols in \"%s\".\n"), bfd_get_filename (abfd));
+      fprintf (stderr, _("%s: no symbols\n"), bfd_get_filename (abfd));
       symcount = 0;
       return NULL;
     }
@@ -393,8 +393,7 @@ slurp_symtab (abfd)
   if (symcount < 0)
     bfd_fatal (bfd_get_filename (abfd));
   if (symcount == 0)
-    fprintf (stderr, _("%s: %s: No symbols\n"),
-            program_name, bfd_get_filename (abfd));
+    fprintf (stderr, _("%s: no symbols\n"), bfd_get_filename (abfd));
   return sy;
 }
 
@@ -1153,8 +1152,8 @@ disassemble_bytes (info, disassemble_fn, insns, data, start, stop, relppp,
      disassembler_ftype disassemble_fn;
      boolean insns;
      bfd_byte *data;
-     long start;
-     long stop;
+     unsigned long start;
+     unsigned long stop;
      arelent ***relppp;
      arelent **relppend;
 {
@@ -1163,7 +1162,7 @@ disassemble_bytes (info, disassemble_fn, insns, data, start, stop, relppp,
   int bytes_per_line;
   boolean done_dot;
   int skip_addr_chars;
-  long i;
+  unsigned long i;
 
   aux = (struct objdump_disasm_info *) info->application_data;
   section = aux->sec;
@@ -1200,7 +1199,7 @@ disassemble_bytes (info, disassemble_fn, insns, data, start, stop, relppp,
   i = start;
   while (i < stop)
     {
-      long z;
+      unsigned long z;
       int bytes;
       boolean need_nl = false;
 
@@ -2627,7 +2626,9 @@ main (argc, argv)
   char *target = default_target;
   boolean seenflag = false;
 
+#ifdef HAVE_SETLOCALE
   setlocale (LC_MESSAGES, "");
+#endif
   bindtextdomain (PACKAGE, LOCALEDIR);
   textdomain (PACKAGE);