mei: amthif: use mei_cl_alloc_cb for allocating cbs
authorAlexander Usyskin <alexander.usyskin@intel.com>
Tue, 24 May 2016 20:03:40 +0000 (16:03 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 30 Aug 2016 12:35:14 +0000 (14:35 +0200)
Use mei_cl_alloc_cb wrapper instead of open code steps

Signed-off-by: Alexander Usyskin <alexander.usyskin@intel.com>
Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/misc/mei/amthif.c

index 9885fa40a120e3f5fea1f06f676ad0e85addcb9b..14b454143c817e90569aa30c0c9fd25fddf56029 100644 (file)
@@ -196,17 +196,10 @@ static int mei_amthif_read_start(struct mei_cl *cl, const struct file *file)
 {
        struct mei_device *dev = cl->dev;
        struct mei_cl_cb *cb;
-       int rets;
-
-       cb = mei_io_cb_init(cl, MEI_FOP_READ, file);
-       if (!cb) {
-               rets = -ENOMEM;
-               goto err;
-       }
 
-       rets = mei_io_cb_alloc_buf(cb, mei_cl_mtu(cl));
-       if (rets)
-               goto err;
+       cb = mei_cl_alloc_cb(cl, mei_cl_mtu(cl), MEI_FOP_READ, file);
+       if (!cb)
+               return -ENOMEM;
 
        list_add_tail(&cb->list, &dev->ctrl_wr_list.list);
 
@@ -214,9 +207,6 @@ static int mei_amthif_read_start(struct mei_cl *cl, const struct file *file)
        dev->iamthif_fp = cb->fp;
 
        return 0;
-err:
-       mei_io_cb_free(cb);
-       return rets;
 }
 
 /**
This page took 0.031456 seconds and 5 git commands to generate.