clockevents/drivers/dw_apb_timer: Implement ->set_state_oneshot_stopped()
authorJisheng Zhang <jszhang@marvell.com>
Fri, 26 Feb 2016 09:45:57 +0000 (17:45 +0800)
committerDaniel Lezcano <daniel.lezcano@linaro.org>
Thu, 28 Apr 2016 13:09:03 +0000 (15:09 +0200)
The dw_apb_timer only "supports PERIODIC mode and their drivers emulate
ONESHOT over that" as described in commit 8fff52fd5093 ("clockevents:
Introduce CLOCK_EVT_STATE_ONESHOT_STOPPED state").

Inspired by Viresh, I think the dw_apb_timer also needs to implement
the set_state_oneshot_stopped() which is called by the clkevt core,
when the next event is required at an expiry time of 'KTIME_MAX'. This
normally happens with NO_HZ_{IDLE|FULL} in both LOWRES/HIGHRES modes.

This patch makes the clockevent device to stop on such an event, to
avoid spurious interrupts, as explained by the above commit.

Signed-off-by: Jisheng Zhang <jszhang@marvell.com>
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Reviewed-by: Viresh Kumar <viresh.kumar@linaro.org>
drivers/clocksource/dw_apb_timer.c

index 63345260244d7d97df303b3fd12445612e6b4395..797505aa2ba41263f5f2080f9b777f383b744bfe 100644 (file)
@@ -264,6 +264,7 @@ dw_apb_clockevent_init(int cpu, const char *name, unsigned rating,
        dw_ced->ced.set_state_shutdown = apbt_shutdown;
        dw_ced->ced.set_state_periodic = apbt_set_periodic;
        dw_ced->ced.set_state_oneshot = apbt_set_oneshot;
+       dw_ced->ced.set_state_oneshot_stopped = apbt_shutdown;
        dw_ced->ced.tick_resume = apbt_resume;
        dw_ced->ced.set_next_event = apbt_next_event;
        dw_ced->ced.irq = dw_ced->timer.irq;
This page took 0.035036 seconds and 5 git commands to generate.