ktest: Fix bug where the test would not end after failure
authorSteven Rostedt <srostedt@redhat.com>
Tue, 8 Mar 2011 14:40:31 +0000 (09:40 -0500)
committerSteven Rostedt <rostedt@goodmis.org>
Tue, 8 Mar 2011 14:52:58 +0000 (09:52 -0500)
The config STOP_AFTER_FAILURE is the number of seconds to continue
the test when a failure is detected. This lets the monitor record
more data to the logs and console that may be helpful in solving
the bug that was found.

But the test had a bug. If the failure caused multiple
"Call Trace" stack dumps, the start time to compare the
STOP_AFTER_FAILURE would constantly be reset. Only update the start
time at the first "Call Trace" instance.

Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
tools/testing/ktest/ktest.pl

index 65c5c5515b478762ba2598e55de44ada66d7cec7..125ab94e7294ce6c9a70415c011ba594edd16462 100755 (executable)
@@ -804,7 +804,7 @@ sub monitor {
        }
 
        if ($full_line =~ /call trace:/i) {
-           if (!$skip_call_trace) {
+           if (!$bug && !$skip_call_trace) {
                $bug = 1;
                $failure_start = time;
            }
This page took 0.027532 seconds and 5 git commands to generate.