arm: ep93xx: Don't try to release not acquired GPIO lines
authorRafal Prylowski <prylowski@metasoft.pl>
Thu, 5 Apr 2012 11:44:07 +0000 (13:44 +0200)
committerRyan Mallon <rmallon@gmail.com>
Wed, 11 Apr 2012 02:07:53 +0000 (12:07 +1000)
Fail path of ep93xx_keypad_acquire_gpio() tries to release
GPIO lines not acquired successfully before. Fix this.

Signed-off-by: Rafal Prylowski <prylowski@metasoft.pl>
Acked-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Signed-off-by: Ryan Mallon <rmallon@gmail.com>
arch/arm/mach-ep93xx/core.c

index 8d2589588713d6c0b717c278660c212cd9f6e17b..2ea2ffc61875a2608ad790a9b8e10919a690f77b 100644 (file)
@@ -734,7 +734,7 @@ int ep93xx_keypad_acquire_gpio(struct platform_device *pdev)
 fail_gpio_d:
        gpio_free(EP93XX_GPIO_LINE_C(i));
 fail_gpio_c:
-       for ( ; i >= 0; --i) {
+       for (--i; i >= 0; --i) {
                gpio_free(EP93XX_GPIO_LINE_C(i));
                gpio_free(EP93XX_GPIO_LINE_D(i));
        }
This page took 0.02577 seconds and 5 git commands to generate.