gdb: handle relative paths to DWO files

DWARF allows .dwo file paths to be relative rather than absolute.

When they are relative, DWARF uses DW_AT_comp_dir to find the .dwo
file.  DW_AT_comp_dir can also be relative, making the entire search
patch for the .dwo file relative.

In this case, GDB currently searches relative to its current working
directory, i.e. the directory from which the debugger was launched,
but not relative to the directory containing the built binary.  This
cannot be right, as the compiler, when generating the relative paths,
knows where it's building the binary but can have no idea where the
debugger will be launched.

The correct thing is to add the directory containing the binary to the
search paths used for resolving relative locations of dwo files. That
is what this patch does.

gdb/ChangeLog:

	* dwarf2/read.c (try_open_dwop_file): Add path for the binary to
	the search paths used resolve relative location of .dwo file.

gdb/testsuite/ChangeLog:

	* gdb.dwarf2/fission-relative-dwo.c: New file.
	* gdb.dwarf2/fission-relative-dwo.exp: New file.

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index b378ccf2e110bea97a36f3f848aeb4f8d55cd5e2..b418b755aa42ab486194f1b34bba7383ac1ff400 100644 (file)
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,8 @@
+2021-04-07  Caroline Tice  <cmtice@google.com>
+
+       * dwarf2/read.c (try_open_dwop_file): Add path for the binary to
+       the search paths used resolve relative location of .dwo file.
+
 2021-04-07  Andrew Burgess  <andrew.burgess@embecosm.com>
 
        * dwarf2/section.c (dwarf2_section_info::get_bfd_owner): Add an

diff --git a/gdb/dwarf2/read.c b/gdb/dwarf2/read.c
index 43433f50d26bdae255a622f768c67b4a8e90f14b..ed0d1c6cc7fe755eee60c861a5bc4fcb2175b374 100644 (file)
--- a/gdb/dwarf2/read.c
+++ b/gdb/dwarf2/read.c
@@ -12723,6 +12723,13 @@ try_open_dwop_file (dwarf2_per_objfile *per_objfile,
   else
     search_path = debug_file_directory;
 
+  /* Add the path for the executable binary to the list of search paths.  */
+  std::string objfile_dir = ldirname (objfile_name (per_objfile->objfile));
+  search_path_holder.reset (concat (objfile_dir.c_str (),
+                                   dirname_separator_string,
+                                   search_path, nullptr));
+  search_path = search_path_holder.get ();
+
   openp_flags flags = OPF_RETURN_REALPATH;
   if (is_dwp)
     flags |= OPF_SEARCH_IN_PATH;

diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog
index ad97b669ccb3aa5c332554de398e5fd8dc06c062..c9c6063c9d14ccd126e98a990ac986b219cbd965 100644 (file)
--- a/gdb/testsuite/ChangeLog
+++ b/gdb/testsuite/ChangeLog
@@ -1,3 +1,8 @@
+2021-04-07  Andrew Burgess  <andrew.burgess@embecosm.com>
+
+       * gdb.dwarf2/fission-relative-dwo.c: New file.
+       * gdb.dwarf2/fission-relative-dwo.exp: New file.
+
 2021-04-07  Andrew Burgess  <andrew.burgess@embecosm.com>
 
        * gdb.dwarf2/fission-absolute-dwo.c: New file.

diff --git a/gdb/testsuite/gdb.dwarf2/fission-relative-dwo.c b/gdb/testsuite/gdb.dwarf2/fission-relative-dwo.c
new file mode 100644 (file)
index 0000000..27f7f0d
--- /dev/null
+++ b/gdb/testsuite/gdb.dwarf2/fission-relative-dwo.c
@@ -0,0 +1,28 @@
+/* This testcase is part of GDB, the GNU debugger.
+
+   Copyright 2021 Free Software Foundation, Inc.
+
+   This program is free software; you can redistribute it and/or modify
+   it under the terms of the GNU General Public License as published by
+   the Free Software Foundation; either version 3 of the License, or
+   (at your option) any later version.
+
+   This program is distributed in the hope that it will be useful,
+   but WITHOUT ANY WARRANTY; without even the implied warranty of
+   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+   GNU General Public License for more details.
+
+   You should have received a copy of the GNU General Public License
+   along with this program.  If not, see
+   <http://www.gnu.org/licenses/>.  */
+
+/* Our fake object.  */
+int global_var[100];
+
+int
+main (int argc, char **argv)
+{
+  asm ("main_label: .globl main_label");
+
+  return 0;
+}

diff --git a/gdb/testsuite/gdb.dwarf2/fission-relative-dwo.exp b/gdb/testsuite/gdb.dwarf2/fission-relative-dwo.exp
new file mode 100644 (file)
index 0000000..566d756
--- /dev/null
+++ b/gdb/testsuite/gdb.dwarf2/fission-relative-dwo.exp
@@ -0,0 +1,130 @@
+# Copyright 2021 Free Software Foundation, Inc.
+
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 3 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program.  If not, see <http://www.gnu.org/licenses/>.
+
+# This test checks that GDB can find the dwo file when the path to the
+# dwo embedded in the executable is relative.
+
+load_lib dwarf.exp
+
+# This test can only be run on targets which support DWARF-2 and use gas.
+if {![dwarf2_support]} {
+    return 0
+}
+
+standard_testfile .c -dw.S
+
+if { [prepare_for_testing "failed to prepare" ${testfile} ${srcfile}] } {
+    return -1
+}
+
+set asm_file [standard_output_file $srcfile2]
+Dwarf::assemble $asm_file {
+    global srcfile gdb_test_file_name
+
+    set debug_addr_base -1
+
+    # The information that will be split out into the .dwo file.
+    cu {fission 1} {
+
+       # Capture the current index into .debug_addr so we can fill in
+       # DW_AT_GNU_addr_base later.
+       set debug_addr_base [debug_addr_label]
+
+       compile_unit {
+            {language @DW_LANG_C}
+            {name ${srcfile}}
+           {DW_AT_comp_dir .}
+           {DW_AT_GNU_dwo_id 0x1234 DW_FORM_data8}
+        } {
+           declare_labels int4_type struct_type
+
+           int4_type: DW_TAG_base_type {
+               {DW_AT_byte_size 4 DW_FORM_sdata}
+               {DW_AT_encoding  @DW_ATE_signed}
+               {DW_AT_name      integer}
+           }
+
+           struct_type: DW_TAG_structure_type {
+               {DW_AT_name "foo_t"}
+               {DW_AT_byte_size 12 DW_FORM_sdata}
+           } {
+               member {
+                   {name "aa"}
+                   {type :$int4_type}
+                   {data_member_location 0 data1}
+               }
+               member {
+                   {name "bb"}
+                   {type :$int4_type}
+                   {data_member_location 4 data1}
+               }
+               member {
+                   {name "cc"}
+                   {type :$int4_type}
+                   {data_member_location 8 data1}
+               }
+           }
+
+           DW_TAG_variable {
+               {DW_AT_name global_var}
+               {DW_AT_type :$struct_type}
+               {DW_AT_location {
+                   DW_OP_GNU_addr_index [gdb_target_symbol global_var]
+               } SPECIAL_expr}
+               {external 1 flag}
+           }
+
+           subprogram {
+               {external 1 flag}
+               {DW_AT_name main DW_FORM_string}
+               {MACRO_AT_func {main}}
+           }
+       }
+    }
+
+    # The information that will remain in the .o file.
+    cu {} {
+       compile_unit {
+            {DW_AT_GNU_dwo_name ${gdb_test_file_name}.dwo DW_FORM_strp}
+           {DW_AT_comp_dir .}
+           {DW_AT_GNU_dwo_id 0x1234 DW_FORM_data8}
+           {DW_AT_GNU_addr_base $debug_addr_base}
+        } {
+           # Nothing.
+       }
+    }
+}
+
+# Compile both source files to create the executable.  As we compile
+# ASM_FILE we split out the debug information into the dwo file.
+set object_file [standard_output_file ${testfile}.o]
+if { [build_executable_and_dwo_files "${testfile}.exp" ${testfile} {nodebug} \
+         [list $asm_file {nodebug split-dwo} ${object_file}] \
+         [list $srcfile {nodebug}]] } {
+    perror "failed to compile ${gdb_test_file_name}"
+    return -1
+}
+
+# Now we can start GDB.
+clean_restart ${testfile}
+
+if ![runto_main] {
+    return -1
+}
+
+# Print the type of global_var.  This type information is entirely
+# fictional, it only exists in the DWARF.  If we don't have the DWARF
+# information then there's no way we can print this.
+gdb_test "p global_var" " = \\{aa = 0, bb = 0, cc = 0\\}"