staging: rts5208: remove extra parentheses around left bit shift operation
authorAya Mahfouz <mahfouz.saif.elyazal@gmail.com>
Wed, 4 Mar 2015 06:19:24 +0000 (08:19 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 6 Mar 2015 23:24:23 +0000 (15:24 -0800)
Removes extra parentheses around bitwise left shift operations.
The case handled is when resultant value is assigned to a variable.
The issue was detected and resolved using the following
coccinelle script:

@@
expression e, e1;
constant c;
@@

e =
-(e1
+e1
<<
-c);
+c;

@@
identifier i;
constant c;
type t;
expression e;
@@

t i =
-(e
+e
<<
-c);
+c;

@@
expression e, e1;
identifier f;
constant c;
@@

e1 = f(...,
-(e
+e
<<
-c)
+c
,...);

Signed-off-by: Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/rts5208/rtsx_transport.c

index dab1995d1a6a5f9276edaaecf876fad2e166de77..03caa9b3771ff1ff1fa9bf0b304f2d9cf69e0c28 100644 (file)
@@ -642,7 +642,7 @@ static int rtsx_transfer_buf(struct rtsx_chip *chip, u8 card, void *buf,
        dma_addr_t addr;
        u8 dir;
        int err = 0;
-       u32 val = (1 << 31);
+       u32 val = 1 << 31;
        long timeleft;
 
        if ((buf == NULL) || (len <= 0))
This page took 0.03367 seconds and 5 git commands to generate.