Current glibc has a bug in fpathconf(fd, _PC_NAME_MAX) where it will
fail with a 32bit userland on a 64bit kernel and where the filesystem
has a large block count, see glibc bug #18675.
In any case, we should check this return value because on a failure we
we don't allocate enough memory for dirent and then overflow on the
readdir_r call.
Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
struct dirent *dirent;
struct dirent *diriter;
size_t dirent_len;
+ int pc_name_max;
char *ext;
td->flags = flags;
* the stream array.
*/
- dirent_len = offsetof(struct dirent, d_name) +
- fpathconf(td->dirfd, _PC_NAME_MAX) + 1;
+ pc_name_max = fpathconf(td->dirfd, _PC_NAME_MAX);
+ if (pc_name_max < 0) {
+ perror("Error on fpathconf");
+ fprintf(stderr, "[error] Failed to get _PC_NAME_MAX for path \"%s\".\n", path);
+ ret = -1;
+ goto error_metadata;
+ }
+
+ dirent_len = offsetof(struct dirent, d_name) + pc_name_max + 1;
dirent = malloc(dirent_len);