change some variable's type to op_err

They only hold values from the op_err enum, so it should be clearer to give
them the enum type.

gas/ChangeLog:

2016-05-24  Trevor Saunders  <tbsaunde+binutils@tbsaunde.org>

	* config/tc-cr16.c (check_range): Make type of retval op_err.
	* config/tc-crx.c: Likewise.

diff --git a/gas/ChangeLog b/gas/ChangeLog
index 64e890b278c33053a2521529634e627ca395e6e4..41518df420aaf3ecc85e760bc0373e8c2886f37f 100644 (file)
--- a/gas/ChangeLog
+++ b/gas/ChangeLog
@@ -1,3 +1,8 @@
+2016-05-24  Trevor Saunders  <tbsaunde+binutils@tbsaunde.org>
+
+       * config/tc-cr16.c (check_range): Make type of retval op_err.
+       * config/tc-crx.c: Likewise.
+
 2016-05-23  Claudiu Zissulescu  <claziss@synopsys.com>
 
        * config/tc-arc.c (md_begin): Add XY registers.

diff --git a/gas/config/tc-cr16.c b/gas/config/tc-cr16.c
index b7fffa7878030277ea74508b746357bafc7f6364..229f51adde23939d6e17d835daa969dd4db36b2a 100644 (file)
--- a/gas/config/tc-cr16.c
+++ b/gas/config/tc-cr16.c
@@ -1993,7 +1993,7 @@ static op_err
 check_range (long *num, int bits, int unsigned flags, int update)
 {
   long min, max;
-  int retval = OP_LEGAL;
+  op_err retval = OP_LEGAL;
   long value = *num;
 
   if (bits == 0 && value > 0) return OP_OUT_OF_RANGE;

diff --git a/gas/config/tc-crx.c b/gas/config/tc-crx.c
index 4b829c2560f7906065fe921d31c60da9efb7ca1d..9a943d530feaf45d03c3aa61e2d309ada3b2801b 100644 (file)
--- a/gas/config/tc-crx.c
+++ b/gas/config/tc-crx.c
@@ -1325,7 +1325,7 @@ static op_err
 check_range (long *num, int bits, int unsigned flags, int update)
 {
   uint32_t max;
-  int retval = OP_LEGAL;
+  op_err retval = OP_LEGAL;
   int bin;
   uint32_t upper_64kb = 0xffff0000;
   uint32_t value = *num;