hwrng: Remove check for max less than 4 bytes
authorPrasannaKumar Muralidharan <prasannatsmkumar@gmail.com>
Fri, 26 Aug 2016 18:32:04 +0000 (00:02 +0530)
committerHerbert Xu <herbert@gondor.apana.org.au>
Wed, 31 Aug 2016 15:00:49 +0000 (23:00 +0800)
HW RNG core never asks for data less than 4 bytes. The check whether max
is less than 4 bytes is unnecessary. Remove the check.

Signed-off-by: PrasannaKumar Muralidharan <prasannatsmkumar@gmail.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
drivers/char/hw_random/meson-rng.c
drivers/char/hw_random/st-rng.c

index 0cfd81bcaeacf492946b5e4f37a612414ed43407..58bef39f72860906068d18f65ab362ffbe1afa78 100644 (file)
@@ -76,9 +76,6 @@ static int meson_rng_read(struct hwrng *rng, void *buf, size_t max, bool wait)
        struct meson_rng_data *data =
                        container_of(rng, struct meson_rng_data, rng);
 
-       if (max < sizeof(u32))
-               return 0;
-
        *(u32 *)buf = readl_relaxed(data->base + RNG_DATA);
 
        return sizeof(u32);
index 1d35363d23c51929eff4d1924bed08684a6587cc..7e8aa6b7b45202600944dc5eecc27d32ca6515e3 100644 (file)
@@ -54,9 +54,6 @@ static int st_rng_read(struct hwrng *rng, void *data, size_t max, bool wait)
        u32 status;
        int i;
 
-       if (max < sizeof(u16))
-               return -EINVAL;
-
        /* Wait until FIFO is full - max 4uS*/
        for (i = 0; i < ST_RNG_FILL_FIFO_TIMEOUT; i++) {
                status = readl_relaxed(ddata->base + ST_RNG_STATUS_REG);
This page took 0.027278 seconds and 5 git commands to generate.