bfd: bfin: drop needless symbol flag handling imported from FRV

The Blackfin bfd merged some FRV code recently, and then removed pieces
that didn't make sense.  In the FRV code, it outputs a "_gp" symbol in
its BFD whereas in the Blackfin code, we don't.  So while on the FRV
side it fiddles with the "flags" variable (sometimes using it for section
flags and sometimes using it for symbol flags), we don't need any of
that.  This lead to BZ 12177 where the Blackfin code is a bit confusing.
So to fix things up, remove more stuff we don't need.  Shouldn't change
the behavior at all.

Signed-off-by: Mike Frysinger <vapier@gentoo.org>

diff --git a/bfd/ChangeLog b/bfd/ChangeLog
index 35aae253018529f82b8ccd4e2f3eeae58788f619..596c57764e8294109b4430673cae749273515da0 100644 (file)
--- a/bfd/ChangeLog
+++ b/bfd/ChangeLog
@@ -1,3 +1,8 @@
+2010-11-15  Mike Frysinger  <vapier@gentoo.org>
+
+       PR binutils/12177
+       * elf32-bfin.c (_bfin_create_got_section): Drop unused flags code.
+
 2010-11-12  H.J. Lu  <hongjiu.lu@intel.com>
 
        * archive.c (_bfd_get_elt_at_filepos): Copy BFD_COMPRESS and

diff --git a/bfd/elf32-bfin.c b/bfd/elf32-bfin.c
index 237391b201ec87c2e3b85f83c1130860db27b6dc..38f31e4f5a931d737c4b3819a364e7a9bb3142c4 100644 (file)
--- a/bfd/elf32-bfin.c
+++ b/bfd/elf32-bfin.c
@@ -3442,14 +3442,8 @@ _bfin_create_got_section (bfd *abfd, struct bfd_link_info *info)
        return FALSE;
 
       bfinfdpic_gotfixup_section (info) = s;
-      flags = BSF_GLOBAL;
-    }
-  else
-    {
-      flags = BSF_GLOBAL | BSF_WEAK;
     }
 
-  flags = pltflags;
   pltflags |= SEC_CODE;
   if (bed->plt_not_loaded)
     pltflags &= ~ (SEC_CODE | SEC_LOAD | SEC_HAS_CONTENTS);