Prevent inlining in gdb.base/vla-optimized-out.c

The function f1 in gdb.base/vla-optimized-out.c sets various
attributes to prevent its being inlined, but Clang inlines it
anyway, causing the test that uses it to fail.  This commit
adds the "weak" attribute to cause Clang to keep the function
fully out of line so the test can operate as it should.

gdb/testsuite/ChangeLog:

	* gdb.base/vla-optimized-out.c (f1): Add __attribute__ ((weak)).

diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog
index 863dcc43463548aa8bec50de469582b49068315d..146fa1a086f144dfd75bd353d48409dcf913043f 100644 (file)
--- a/gdb/testsuite/ChangeLog
+++ b/gdb/testsuite/ChangeLog
@@ -1,3 +1,7 @@
+2020-11-10  Gary Benson <gbenson@redhat.com>
+
+       * gdb.base/vla-optimized-out.c (f1): Add __attribute__ ((weak)).
+
 2020-11-10  Gary Benson <gbenson@redhat.com>
 
        * gdb.cp/step-and-next-inline.exp: Only require

diff --git a/gdb/testsuite/gdb.base/vla-optimized-out.c b/gdb/testsuite/gdb.base/vla-optimized-out.c
index d21df7a153e94c940fdb6853966100b03d6ba7c6..1bd4f6d140630df006e5724a0ccb3caf64d5b7b5 100644 (file)
--- a/gdb/testsuite/gdb.base/vla-optimized-out.c
+++ b/gdb/testsuite/gdb.base/vla-optimized-out.c
@@ -22,9 +22,9 @@
 
 int
 #ifdef NOCLONE
-__attribute__((noinline)) ATTRIBUTE_NOCLONE
+__attribute__((noinline,weak)) ATTRIBUTE_NOCLONE
 #else
-__attribute__((noinline))
+__attribute__((noinline,weak))
 #endif
 f1 (int i)
 {