tmf: Execute TmfEventTable's request handler only on success

The handler for the TmfTimeSynchSignal in TmfEventsTable sends an event
request to "position" the experiment to the correct timestamp/event. This
request executes a seek() on the experiment itself, and is located in the
handleCompleted() callback.

It should be moved to the handleSuccess() callback instead: this
repositioning of the experiment should only be done when the request
finishes succesfully. It should not be run if the request was cancelled,
for example because the executor was flooded with requests and cancelled
some of them.

Partial fix for bug 451615.

Change-Id: I905bb5d19aa0fe40f9d63bfd2e4f60d90aba3050
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/36517
Tested-by: Hudson CI

diff --git a/org.eclipse.tracecompass.tmf.ui/src/org/eclipse/tracecompass/tmf/ui/viewers/events/TmfEventsTable.java b/org.eclipse.tracecompass.tmf.ui/src/org/eclipse/tracecompass/tmf/ui/viewers/events/TmfEventsTable.java
index 958ba549b769d63cf01cdbea57f9913e7d9aa6e6..e01f4058c3e87cf5bf95b2dd331a5951cd0eb46e 100644 (file)
--- a/org.eclipse.tracecompass.tmf.ui/src/org/eclipse/tracecompass/tmf/ui/viewers/events/TmfEventsTable.java
+++ b/org.eclipse.tracecompass.tmf.ui/src/org/eclipse/tracecompass/tmf/ui/viewers/events/TmfEventsTable.java
@@ -2463,8 +2463,8 @@ public class TmfEventsTable extends TmfComponent implements IGotoMarker, IColorS
                 }
 
                 @Override
-                public void handleCompleted() {
-                    super.handleCompleted();
+                public void handleSuccess() {
+                    super.handleSuccess();
                     if (fTrace == null) {
                         return;
                     }