staging: comedi: ni_pcidio: remove use of comedi_error()
authorH Hartley Sweeten <hsweeten@visionengravers.com>
Thu, 17 Jul 2014 18:57:32 +0000 (11:57 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 18 Jul 2014 00:59:01 +0000 (17:59 -0700)
The comedi_error() function is just a wrapper around dev_err() that adds
the dev->driver->driver_name prefix to the message and a terminating
new-line character. The addition of the driver_name is just added noise
and some of the users of comedi_error() add unnecessary additional new-line
characters.

Use dev_err() directly instead of comedi_error() to avoid any confusion
and so that all the comedi generated kernel messages have the same format.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/comedi/drivers/ni_pcidio.c

index ac800daa291a37ecc9c6609b74ab14843deded49..7bc4b9f127f30944431db1d103f3c1ace24c1a62 100644 (file)
@@ -319,7 +319,7 @@ static int ni_pcidio_request_di_mite_channel(struct comedi_device *dev)
                                          devpriv->di_mite_ring, 1, 2);
        if (devpriv->di_mite_chan == NULL) {
                spin_unlock_irqrestore(&devpriv->mite_channel_lock, flags);
-               comedi_error(dev, "failed to reserve mite dma channel.");
+               dev_err(dev->class_dev, "failed to reserve mite dma channel\n");
                return -EBUSY;
        }
        devpriv->di_mite_chan->dir = COMEDI_INPUT;
This page took 0.026099 seconds and 5 git commands to generate.