sim: moxie: fix leakage in error path [BZ #18273]

Reported-by: dcb <dcb314@hotmail.com>

diff --git a/sim/moxie/ChangeLog b/sim/moxie/ChangeLog
index fe37e82eacfde7823ca30c73f11b395b4b4aa59b..04b74ce277a39574425af5af6e401d9fcb27aa94 100644 (file)
--- a/sim/moxie/ChangeLog
+++ b/sim/moxie/ChangeLog
@@ -1,3 +1,8 @@
+2015-10-11  Mike Frysinger  <vapier@gentoo.org>
+
+       PR sim/18273
+       * interp.c (load_dtb): Close open file in error path.
+
 2015-06-23  Mike Frysinger  <vapier@gentoo.org>
 
        * configure: Regenerate.

diff --git a/sim/moxie/interp.c b/sim/moxie/interp.c
index 35ee2a70a83f523506a64259241c48fa45e416b1..df92cee39d9d68b20b6b84da1a0fcc6e9adcdfd1 100644 (file)
--- a/sim/moxie/interp.c
+++ b/sim/moxie/interp.c
@@ -1273,6 +1273,7 @@ load_dtb (SIM_DESC sd, const char *filename)
   if (size != fread (buf, 1, size, f))
     {
       sim_io_eprintf (sd, "ERROR: error reading ``%s''.\n", filename);
+      fclose (f);
       return;
     }
   sim_core_write_buffer (sd, scpu, write_map, buf, 0xE0000000, size);