ctf: rename ctx_create to ctf_visitor_generate_ir_create

There is an unnecessary level here, rename the existing ctx_create to
ctf_visitor_generate_ir_create.  Remove the existing
ctf_visitor_generate_ir_create.

Change-Id: I2ce578f30e1e9e25754dc9ad4f18610eb3a0be36
Signed-off-by: Simon Marchi <simon.marchi@efficios.com>
Reviewed-on: https://review.lttng.org/c/babeltrace/+/8424
Reviewed-by: Philippe Proulx <eeppeliteloop@gmail.com>

diff --git a/src/plugins/ctf/common/src/metadata/tsdl/visitor-generate-ir.cpp b/src/plugins/ctf/common/src/metadata/tsdl/visitor-generate-ir.cpp
index 336ff33f19c0e3459df5441b9d6ab0755bafd66e..577c917c62014fbfab01d420723a2011abcf26d6 100644 (file)
--- a/src/plugins/ctf/common/src/metadata/tsdl/visitor-generate-ir.cpp
+++ b/src/plugins/ctf/common/src/metadata/tsdl/visitor-generate-ir.cpp
@@ -497,15 +497,10 @@ ctf_visitor_generate_ir::~ctf_visitor_generate_ir()
     }
 }
 
-/**
- * Creates a new visitor context.
- *
- * @param trace        Associated trace
- * @returns    New visitor context, or NULL on error
- */
-static ctf_visitor_generate_ir::UP ctx_create(const ctf::src::ClkClsCfg clkClsCfg,
-                                              bt_self_component *selfComp,
-                                              const bt2_common::LogCfg& logCfg)
+BT_HIDDEN
+ctf_visitor_generate_ir::UP ctf_visitor_generate_ir_create(const ctf::src::ClkClsCfg clkClsCfg,
+                                                           bt_self_component *selfComp,
+                                                           const bt2_common::LogCfg& logCfg)
 {
     ctf_visitor_generate_ir::UP ctx =
         bt2_common::makeUnique<ctf_visitor_generate_ir>(clkClsCfg, selfComp, logCfg);
@@ -4398,27 +4393,6 @@ end:
     return ret;
 }
 
-BT_HIDDEN
-ctf_visitor_generate_ir::UP ctf_visitor_generate_ir_create(const ctf::src::ClkClsCfg clkClsCfg,
-                                                           bt_self_component *selfComp,
-                                                           const bt2_common::LogCfg& logCfg)
-{
-    /* Create visitor's context */
-    ctf_visitor_generate_ir::UP ctx = ctx_create(clkClsCfg, selfComp, logCfg);
-    if (!ctx) {
-        BT_CLOGE_APPEND_CAUSE_EX(logCfg, "Cannot create visitor's context.");
-        goto error;
-    }
-
-    goto end;
-
-error:
-    ctx.reset();
-
-end:
-    return ctx;
-}
-
 BT_HIDDEN
 nonstd::optional<bt2::TraceClass::Shared>
 ctf_visitor_generate_ir_get_ir_trace_class(struct ctf_visitor_generate_ir *ctx)