clk: lpc32xx: fix compilation warning
authorSylvain Lemieux <slemieux@tycoint.com>
Tue, 23 Feb 2016 19:56:09 +0000 (14:56 -0500)
committerStephen Boyd <sboyd@codeaurora.org>
Thu, 3 Mar 2016 19:41:43 +0000 (11:41 -0800)
Remove the following false positives compilation warning:
- drivers/clk/nxp/clk-lpc32xx.c: In function 'lpc32xx_clk_register':
  warning: 'hw' may be used uninitialized in this function [-Wmaybe-uninitialized]
- drivers/clk/nxp/clk-lpc32xx.c: In function 'clk_hclk_pll_round_rate':
  warning: 'p' may be used uninitialized in this function [-Wmaybe-uninitialized]
  warning: 'n' may be used uninitialized in this function [-Wmaybe-uninitialized]
  warning: 'm' may be used uninitialized in this function [-Wmaybe-uninitialized]

Tested using gcc version 4.7.3.

Signed-off-by: Sylvain Lemieux <slemieux@tycoint.com>
[sboyd@codeaurora.org: Drop assignment of hw to NULL as return
silences it and is less likely to lead to hiding problems later]
Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
drivers/clk/nxp/clk-lpc32xx.c

index 48b3a11aa09a9e48bd962528eef69ae06c8c6022..481b2646b4964ba5974dc7a4f4f0f40742796b3e 100644 (file)
@@ -588,7 +588,8 @@ static long clk_hclk_pll_round_rate(struct clk_hw *hw, unsigned long rate,
                                    unsigned long *parent_rate)
 {
        struct lpc32xx_pll_clk *clk = to_lpc32xx_pll_clk(hw);
-       u64 m_i, m, n, p, o = rate, i = *parent_rate, d = (u64)rate << 6;
+       u64 m_i, o = rate, i = *parent_rate, d = (u64)rate << 6;
+       u64 m = 0, n = 0, p = 0;
        int p_i, n_i;
 
        pr_debug("%s: %lu/%lu\n", clk_hw_get_name(hw), *parent_rate, rate);
@@ -1428,6 +1429,8 @@ static struct clk * __init lpc32xx_clk_register(u32 id)
                        hw = &clk_hw->hw0.div.hw;
                else if (clk_hw->type == CLK_GATE)
                        hw = &clk_hw->hw0.gate.hw;
+               else
+                       return ERR_PTR(-EINVAL);
 
                hw->init = &clk_init;
                clk = clk_register(NULL, hw);
This page took 0.030622 seconds and 5 git commands to generate.