[AArch64][SVE 10/32] Move range check out of parse_aarch64_imm_float

Since some SVE constants are no longer explicitly tied to the 8-bit
FP immediate format, it seems better to move the range checks out of
parse_aarch64_imm_float and into the callers.

gas/
	* config/tc-aarch64.c (parse_aarch64_imm_float): Remove range check.
	(parse_operands): Check the range of 8-bit FP immediates here instead.

diff --git a/gas/ChangeLog b/gas/ChangeLog
index 70f0e71841509fad50f1def9253fb35cedc494f3..28b12b4323a0b40d8d0cf16bd3860b57803814d8 100644 (file)
--- a/gas/ChangeLog
+++ b/gas/ChangeLog
@@ -1,3 +1,8 @@
+2016-09-21  Richard Sandiford  <richard.sandiford@arm.com>
+
+       * config/tc-aarch64.c (parse_aarch64_imm_float): Remove range check.
+       (parse_operands): Check the range of 8-bit FP immediates here instead.
+
 2016-09-21  Richard Sandiford  <richard.sandiford@arm.com>
 
        * config/tc-aarch64.c (parse_aarch64_imm_float): Report a specific

diff --git a/gas/config/tc-aarch64.c b/gas/config/tc-aarch64.c
index 388c4bfa20f4b0f36250e4096956da80fe99f6e1..2489d5bc1d26a9c0bf84747af4115b2c80b39fd2 100644 (file)
--- a/gas/config/tc-aarch64.c
+++ b/gas/config/tc-aarch64.c
@@ -2148,7 +2148,8 @@ can_convert_double_to_float (uint64_t imm, uint32_t *fpword)
    hexadecimal representation is involved).  REG_TYPE says which register
    names should be treated as registers rather than as symbolic immediates.
 
-   N.B. 0.0 is accepted by this function.  */
+   This routine accepts any IEEE float; it is up to the callers to reject
+   invalid ones.  */
 
 static bfd_boolean
 parse_aarch64_imm_float (char **ccp, int *immed, bfd_boolean dp_p,
@@ -2224,12 +2225,9 @@ parse_aarch64_imm_float (char **ccp, int *immed, bfd_boolean dp_p,
        }
     }
 
-  if (aarch64_imm_float_p (fpword) || fpword == 0)
-    {
-      *immed = fpword;
-      *ccp = str;
-      return TRUE;
-    }
+  *immed = fpword;
+  *ccp = str;
+  return TRUE;
 
 invalid_fp:
   set_fatal_syntax_error (_("invalid floating-point constant"));
@@ -5296,7 +5294,7 @@ parse_operands (char *str, const aarch64_opcode *opcode)
              = (aarch64_get_qualifier_esize (inst.base.operands[0].qualifier)
                 == 8);
            if (!parse_aarch64_imm_float (&str, &qfloat, dp_p, imm_reg_type)
-               || qfloat == 0)
+               || !aarch64_imm_float_p (qfloat))
              {
                if (!error_p ())
                  set_fatal_syntax_error (_("invalid floating-point"