ERROR: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit
0123456789ab ("commit description")'
#12:
commit
7c9cb38302e78d24e37f7d8a2ea7eed4ae5f2fa7
WARNING: line over 80 characters
#87: FILE: kernel/relay.c:337:
+ struct rchan_buf *buf = container_of(work, struct rchan_buf, wakeup_work);
WARNING: waitqueue_active without comment
#119: FILE: kernel/relay.c:772:
+ if (waitqueue_active(&buf->read_wait)) {
total: 1 errors, 2 warnings, 70 lines checked
NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.
./patches/relay-use-irq_work-instead-of-plain-timer-for-deferred-wakeup.patch has style problems, please review.
NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
Please run checkpatch prior to sending patches
Cc: Akash Goel <akash.goel@intel.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
*/
static void wakeup_readers(struct irq_work *work)
{
- struct rchan_buf *buf = container_of(work, struct rchan_buf, wakeup_work);
+ struct rchan_buf *buf;
+
+ buf = container_of(work, struct rchan_buf, wakeup_work);
wake_up_interruptible(&buf->read_wait);
}