atmel_lcdfb: move lcdcon2 register access to compute_hozval
authorJohan Hovold <jhovold@gmail.com>
Thu, 7 Feb 2013 15:31:57 +0000 (16:31 +0100)
committerNicolas Ferre <nicolas.ferre@atmel.com>
Wed, 13 Mar 2013 10:05:12 +0000 (11:05 +0100)
Pass atmel_lcd_info structure to compute_hozval and only do the register
access on SOCs that actually use it.

This will also simplify the removal of the cpu_is macros.

Signed-off-by: Johan Hovold <jhovold@gmail.com>
Signed-off-by: Nicolas Ferre <nicolas.ferre@atmel.com>
drivers/video/atmel_lcdfb.c

index c5883cafa38a831b07ae7bf708e64e412b06a21a..2effd35da5893d8eb9ddffb19f6c355e385ab93a 100644 (file)
@@ -193,14 +193,17 @@ static struct fb_fix_screeninfo atmel_lcdfb_fix __initdata = {
        .accel          = FB_ACCEL_NONE,
 };
 
-static unsigned long compute_hozval(unsigned long xres, unsigned long lcdcon2)
+static unsigned long compute_hozval(struct atmel_lcdfb_info *sinfo,
+                                                       unsigned long xres)
 {
+       unsigned long lcdcon2;
        unsigned long value;
 
        if (!(cpu_is_at91sam9261() || cpu_is_at91sam9g10()
                || cpu_is_at32ap7000()))
                return xres;
 
+       lcdcon2 = lcdc_readl(sinfo, ATMEL_LCDC_LCDCON2);
        value = xres;
        if ((lcdcon2 & ATMEL_LCDC_DISTYPE) != ATMEL_LCDC_DISTYPE_TFT) {
                /* STN display */
@@ -591,8 +594,7 @@ static int atmel_lcdfb_set_par(struct fb_info *info)
        lcdc_writel(sinfo, ATMEL_LCDC_TIM2, value);
 
        /* Horizontal value (aka line size) */
-       hozval_linesz = compute_hozval(info->var.xres,
-                                       lcdc_readl(sinfo, ATMEL_LCDC_LCDCON2));
+       hozval_linesz = compute_hozval(sinfo, info->var.xres);
 
        /* Display size */
        value = (hozval_linesz - 1) << ATMEL_LCDC_HOZVAL_OFFSET;
This page took 0.02526 seconds and 5 git commands to generate.