* tc-m68k.c (try_index): Error if index scaling specified and

assembling for an older CPU than a 68020.

This bug was found at Adobe because GAS did not diagnose incorrect
68020 code generated by GCC when compiling for 68010.  We had to debug it
in the target system as failing instructions.

diff --git a/gas/config/ChangeLog b/gas/config/ChangeLog
index d334c7471e7366d45e3882c768c530613bbe6b10..f085b34166fb640c4473f563515a952865de14c1 100644 (file)
--- a/gas/config/ChangeLog
+++ b/gas/config/ChangeLog
@@ -1,8 +1,12 @@
+Wed Aug  5 01:54:34 1992  John Gilmore  (gnu at cygnus.com)
+
+       * tc-m68k.c (try_index):  Error if index scaling specified and
+       assembling for an older CPU than a 68020.
+
 Mon Jul  6 17:09:32 1992  Steve Chamberlain  (sac@cygnus.com)
 
        * obj-coffbfd.c (fill_section): mark .lit sections as STYP_LIT
 
-
 Tue Jun  9 07:50:46 1992  Steve Chamberlain  (sac@thepub.cygnus.com)
 
        * tc-m68k.c (m68kip): Fix typo so that only arch's >=68020 do
@@ -21,7 +25,6 @@ Mon May  4 18:56:19 1992  Steve Chamberlain  (sac@thepub.cygnus.com)
        * obj-coffbfd.c: use is a synonym for section, (do_relocs_for):
        calc the base of relocs correctly.
        * tc-a29k.c (parse_operand): allow expressions to be in any section.
-       
 
 Thu Mar 12 04:42:38 1992  K. Richard Pixley  (rich@cygnus.com)
 

diff --git a/gas/config/tc-m68k.c b/gas/config/tc-m68k.c
index 15bdf999c6af1846a5151aba64295646537b87e3..7ccd0031e70c521418350901003e8c33d0bef26d 100644 (file)
--- a/gas/config/tc-m68k.c
+++ b/gas/config/tc-m68k.c
@@ -892,6 +892,11 @@ struct m68k_op *opP;
                case '2':
                case '4':
                case '8':
+                       if (cpu_of_arch(current_architecture) < m68020) {
+                               opP->error="no index scaling in pre-68020's";
+                               *s=ss;
+                               return FAIL;
+                       }
                        opP->imul= *ss-'0';
                        break;
                default: