hwmon: (emc2103) Return error from i2c_smbus_read_byte_data
authorGuenter Roeck <linux@roeck-us.net>
Wed, 12 Feb 2014 05:34:21 +0000 (21:34 -0800)
committerGuenter Roeck <linux@roeck-us.net>
Mon, 3 Mar 2014 16:01:04 +0000 (08:01 -0800)
There is no reason to replace one error with another.

smatch message:
drivers/hwmon/emc2103.c:352 set_fan_div() info: why not propagate 'status'
from i2c_smbus_read_byte_data() instead of (-5)?

Reviewed-by: Jean Delvare <jdelvare@suse.de>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
drivers/hwmon/emc2103.c

index 2c137b26acb48bbe188243a189f05c1c8ed693c5..fd892dd48e4c28ffe70c323f2238e893df20f63c 100644 (file)
@@ -349,7 +349,7 @@ static ssize_t set_fan_div(struct device *dev, struct device_attribute *da,
                dev_dbg(&client->dev, "reg 0x%02x, err %d\n",
                        REG_FAN_CONF1, status);
                mutex_unlock(&data->update_lock);
-               return -EIO;
+               return status;
        }
        status &= 0x9F;
        status |= (new_range_bits << 5);
This page took 0.029156 seconds and 5 git commands to generate.