staging: unisys: virthba: remove extra parentheses around left bit shift operations
authorAya Mahfouz <mahfouz.saif.elyazal@gmail.com>
Wed, 4 Mar 2015 06:20:14 +0000 (08:20 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 6 Mar 2015 23:24:23 +0000 (15:24 -0800)
Removes extra parentheses around bitwise left shift operations.
The case handled is when resultant value is assigned to a variable.
The issue was detected and resolved using the following
coccinelle script:

@@
expression e, e1;
constant c;
@@

e =
-(e1
+e1
<<
-c);
+c;

@@
identifier i;
constant c;
type t;
expression e;
@@

t i =
-(e
+e
<<
-c);
+c;

@@
expression e, e1;
identifier f;
constant c;
@@

e1 = f(...,
-(e
+e
<<
-c)
+c
,...);

Signed-off-by: Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/unisys/virthba/virthba.c

index ca89e76fbf7e91a899e41d414afe0827b797ba40..2ad0c19396233cd4b95dc12b388f4b4bdf18596b 100644 (file)
@@ -1534,7 +1534,7 @@ virthba_serverdown_complete(struct work_struct *work)
                switch (pendingdel->cmdtype) {
                case CMD_SCSI_TYPE:
                        scsicmd = (struct scsi_cmnd *)pendingdel->sent;
-                       scsicmd->result = (DID_RESET << 16);
+                       scsicmd->result = DID_RESET << 16;
                        if (scsicmd->scsi_done)
                                scsicmd->scsi_done(scsicmd);
                        break;
This page took 0.036078 seconds and 5 git commands to generate.