driver core: don't trigger uevent after failure

Do not send the uevent if driver_add_groups failed.

Reported-by: Ming Lei <ming.lei@canonical.com>
Signed-off-by: Sebastian Ott <sebott@linux.vnet.ibm.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/base/driver.c b/drivers/base/driver.c
index 1b500d6fcc2eec080a2acd6c457b773b64fde85d..974e301a1ef07ae02064be5e003bc4ac034df5c7 100644 (file)
--- a/drivers/base/driver.c
+++ b/drivers/base/driver.c
@@ -185,9 +185,10 @@ int driver_register(struct device_driver *drv)
        if (ret)
                return ret;
        ret = driver_add_groups(drv, drv->groups);
-       if (ret)
+       if (ret) {
                bus_remove_driver(drv);
-
+               return ret;
+       }
        kobject_uevent(&drv->p->kobj, KOBJ_ADD);
 
        return ret;