Staging: gdm724x: Fix unchecked sscanf values in gdm_lte.c
authorMonam Agarwal <monamagarwal123@gmail.com>
Sun, 16 Mar 2014 10:08:39 +0000 (15:38 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 18 Mar 2014 18:35:53 +0000 (11:35 -0700)
This patch fixes following checkpatch.pl warning:
WARNING: unchecked sscanf value in gdm_lte.c

Signed-off-by: Monam Agarwal <monamagarwal123@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/gdm724x/gdm_lte.c

index 0ddb65d5400035f221d000706e12ac9751ef2379..64c55b99fda4594725112d0d17b299ffe78bdbfb 100644 (file)
@@ -468,7 +468,11 @@ static int gdm_lte_tx(struct sk_buff *skb, struct net_device *dev)
        if (!(nic_type & NIC_TYPE_F_DHCP))
                nic_type &= NIC_TYPE_MASK;
 
-       sscanf(dev->name, "lte%d", &idx);
+       ret = sscanf(dev->name, "lte%d", &idx);
+       if (ret != 1) {
+               dev_kfree_skb(skb);
+               return -EINVAL;
+       }
 
        ret = nic->phy_dev->send_sdu_func(nic->phy_dev->priv_dev,
                                          data_buf, data_len,
@@ -509,8 +513,11 @@ static int gdm_lte_event_send(struct net_device *dev, char *buf, int len)
        struct nic *nic = netdev_priv(dev);
        struct hci_packet *hci = (struct hci_packet *)buf;
        int idx;
+       int ret;
 
-       sscanf(dev->name, "lte%d", &idx);
+       ret = sscanf(dev->name, "lte%d", &idx);
+       if (ret != 1)
+               return -EINVAL;
 
        return netlink_send(lte_event.sock, idx, 0, buf,
                            gdm_dev16_to_cpu(
This page took 0.027616 seconds and 5 git commands to generate.