HID: logitech-dj: Allow incoming packets during probe().
authorAndrew de los Reyes <adlr@chromium.org>
Mon, 18 Feb 2013 17:20:22 +0000 (09:20 -0800)
committerJiri Kosina <jkosina@suse.cz>
Fri, 1 Mar 2013 13:14:35 +0000 (14:14 +0100)
Historically, logitech-dj communicated with the device during probe()
to query the list of devices attached. Later, a change was introduced
to hid-core that prevented incoming packets for a device during
probe(), as many drivers are unable to handle such input. That change
broke the device enumeration in logitech-dj, so commit
596264082f10dd4a56 was introduced to workaround that by waiting for
normal input before enumerating devices.

Now that drivers can opt-in to receive input during probe, this patch
changes logitech-dj to do that, so that it can successfully complete
enumeration of devices during probe().

Signed-off-by: Andrew de los Reyes <adlr@chromium.org>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
drivers/hid/hid-logitech-dj.c

index 9500f2f3f8fea702432e683a56dc0eea53dbf3fe..bf647ef18086789558aa70ebc4903161c94fa8d2 100644 (file)
@@ -803,6 +803,9 @@ static int logi_dj_probe(struct hid_device *hdev,
                goto llopen_failed;
        }
 
+       /* Allow incoming packets to arrive: */
+       hid_device_io_start(hdev);
+
        retval = logi_dj_recv_query_paired_devices(djrcv_dev);
        if (retval < 0) {
                dev_err(&hdev->dev, "%s:logi_dj_recv_query_paired_devices "
This page took 0.025114 seconds and 5 git commands to generate.