dlm: config: using strlcpy instead of strncpy
authorZhao Hongjiang <zhaohongjiang@huawei.com>
Thu, 20 Jun 2013 10:59:51 +0000 (18:59 +0800)
committerDavid Teigland <teigland@redhat.com>
Tue, 25 Jun 2013 17:53:06 +0000 (12:53 -0500)
for NUL terminated string, need alway set '\0' in the end.

Signed-off-by: Zhao Hongjiang <zhaohongjiang@huawei.com>
Signed-off-by: David Teigland <teigland@redhat.com>
fs/dlm/config.c

index 7d58d5b112b559ccc9a9145a003f15e076d8a27b..76feb4b60fa6d0a307d70b216a7d4a91cdf389ba 100644 (file)
@@ -138,8 +138,9 @@ static ssize_t cluster_cluster_name_read(struct dlm_cluster *cl, char *buf)
 static ssize_t cluster_cluster_name_write(struct dlm_cluster *cl,
                                          const char *buf, size_t len)
 {
-       strncpy(dlm_config.ci_cluster_name, buf, DLM_LOCKSPACE_LEN);
-       strncpy(cl->cl_cluster_name, buf, DLM_LOCKSPACE_LEN);
+       strlcpy(dlm_config.ci_cluster_name, buf,
+                               sizeof(dlm_config.ci_cluster_name));
+       strlcpy(cl->cl_cluster_name, buf, sizeof(cl->cl_cluster_name));
        return len;
 }
 
This page took 0.025372 seconds and 5 git commands to generate.