projects
/
deliverable
/
linux.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
9966c37
)
HID: picoLCD: prevent NULL pointer dereference on unplug
author
Bruno Prémont
<bonbons@linux-vserver.org>
Mon, 30 Jul 2012 19:38:50 +0000
(21:38 +0200)
committer
Jiri Kosina
<jkosina@suse.cz>
Wed, 15 Aug 2012 08:11:43 +0000
(10:11 +0200)
[ 679.807480] BUG: unable to handle kernel NULL pointer dereference at
00000074
[ 679.814457] IP: [<
de93b5bf
>] picolcd_led_set_brightness+0x1f/0xb0 [hid_picolcd]
[ 679.814457] *pde =
00000000
[ 679.814457] Oops: 0000 [#1]
[ 679.814457] Modules linked in: hid_picolcd fb_sys_fops sysimgblt sysfillrect syscopyarea drm_kms_helper nfs lockd nfs_acl sunrpc [last unloaded: hid_picolcd]
[ 679.814457]
[ 679.814457] Pid: 272, comm: khubd Not tainted
3.5.0-jupiter-00006-g463a4c0
#1 NVIDIA Corporation. nFORCE-MCP/MS-6373
[ 679.814457] EIP: 0060:[<
de93b5bf
>] EFLAGS:
00010246
CPU: 0
[ 679.814457] EIP is at picolcd_led_set_brightness+0x1f/0xb0 [hid_picolcd]
[ 679.814457] EAX:
00000000
EBX:
d9f0c4e0
ECX:
00000000
EDX:
00000000
[ 679.814457] ESI:
00000000
EDI:
dd6b79c0
EBP:
dd4f7d90
ESP:
dd4f7d80
[ 679.814457] DS: 007b ES: 007b FS: 0000 GS: 00e0 SS: 0068
[ 679.814457] CR0:
8005003b
CR2:
00000074
CR3:
1d74e000
CR4:
000007d0
[ 679.814457] DR0:
00000000
DR1:
00000000
DR2:
00000000
DR3:
00000000
[ 679.814457] DR6:
ffff0ff0
DR7:
00000400
[ 679.814457] Process khubd (pid: 272, ti=
dd4f6000
task=
dd442470
task.ti=
dd4f6000
)
[ 679.814457] Stack:
[ 679.814457]
1d6c3300
d9f0c4e0
d9f0c4e0
dd6b79c0
dd4f7da0
c132912a
00000000
d9f0c4e0
[ 679.814457]
dd4f7dac
c132935d
00000000
dd4f7dc0
de93b847
dd6b79c0
00000282
c700ecc8
[ 679.814457]
dd4f7ddc
de93924f
00000004
c700ecc8
c700e060
c700ecbc
c15ee300
dd4f7dec
[ 679.814457] Call Trace:
[ 679.814457] [<
c132912a
>] led_brightness_set+0x2a/0x30
[ 679.814457] [<
c132935d
>] led_classdev_unregister+0xd/0x50
[ 679.814457] [<
de93b847
>] picolcd_exit_leds+0x27/0x40 [hid_picolcd]
[ 679.814457] [<
de93924f
>] picolcd_remove+0xbf/0x110 [hid_picolcd]
[ 679.814457] [<
c132c5dd
>] hid_device_remove+0x3d/0x80
[ 679.814457] [<
c1294126
>] __device_release_driver+0x56/0xa0
[ 679.814457] [<
c1294190
>] device_release_driver+0x20/0x30
[ 679.814457] [<
c1293bbf
>] bus_remove_device+0x9f/0xc0
[ 679.814457] [<
c1291a1d
>] device_del+0xdd/0x150
[ 679.814457] [<
c132c205
>] hid_destroy_device+0x25/0x60
[ 679.814457] [<
c13368cb
>] usbhid_disconnect+0x1b/0x40
[ 679.814457] [<
c12f4976
>] usb_unbind_interface+0x46/0x170
[ 679.814457] [<
c1294126
>] __device_release_driver+0x56/0xa0
[ 679.814457] [<
c1294190
>] device_release_driver+0x20/0x30
[ 679.814457] [<
c1293bbf
>] bus_remove_device+0x9f/0xc0
[ 679.814457] [<
c1291a1d
>] device_del+0xdd/0x150
[ 679.814457] [<
c12f2975
>] usb_disable_device+0x85/0x1a0
[ 679.814457] [<
c1053146
>] ? __cond_resched+0x16/0x30
[ 679.814457] [<
c12ebdb0
>] usb_disconnect+0x80/0xf0
[ 679.814457] [<
c12ed61f
>] hub_thread+0x3df/0x1030
[ 679.814457] [<
c10484a0
>] ? wake_up_bit+0x30/0x30
[ 679.814457] [<
c12ed240
>] ? usb_remote_wakeup+0x40/0x40
[ 679.814457] [<
c1047f94
>] kthread+0x74/0x80
[ 679.814457] [<
c1047f20
>] ? flush_kthread_worker+0x90/0x90
[ 679.814457] [<
c140e33e
>] kernel_thread_helper+0x6/0xd
[ 679.814457] Code: e0 25 00 e0 ff ff ff 48 14 eb 99 90 55 89 e5 83 ec 10 89 5d f4 89 75 f8 89 c3 89 7d fc 8b 40 1c 89 d6 8b 00 e8 13 89 95 e2 31 c9 <39> 5c 88 74 74 13 41 83 f9 08 75 f4 8b 5d f4 8b 75 f8 8b 7d fc
[ 679.814457] EIP: [<
de93b5bf
>] picolcd_led_set_brightness+0x1f/0xb0 [hid_picolcd] SS:ESP 0068:
dd4f7d80
[ 679.814457] CR2:
0000000000000074
[ 680.116438] ---[ end trace
6f0d9d63bff280ff
]---
Signed-off-by: Bruno Prémont <bonbons@linux-vserver.org>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
drivers/hid/hid-picolcd_leds.c
patch
|
blob
|
blame
|
history
diff --git
a/drivers/hid/hid-picolcd_leds.c
b/drivers/hid/hid-picolcd_leds.c
index 9249c068a4851fdfd8a3b77ff8152d40f52a52b9..5573cd8b240bd9f1ddfae6a4f63bd2b74198b9c2 100644
(file)
--- a/
drivers/hid/hid-picolcd_leds.c
+++ b/
drivers/hid/hid-picolcd_leds.c
@@
-69,6
+69,8
@@
static void picolcd_led_set_brightness(struct led_classdev *led_cdev,
dev = led_cdev->dev->parent;
hdev = container_of(dev, struct hid_device, dev);
data = hid_get_drvdata(hdev);
+ if (!data)
+ return;
for (i = 0; i < 8; i++) {
if (led_cdev != data->led[i])
continue;
This page took
0.026676 seconds
and
5
git commands to generate.