pinctrl: st: Fix error check for of_irq_to_resource usage
authorSrinivas Kandagatla <srinivas.kandagatla@st.com>
Wed, 12 Mar 2014 13:35:05 +0000 (13:35 +0000)
committerLinus Walleij <linus.walleij@linaro.org>
Wed, 12 Mar 2014 14:53:44 +0000 (15:53 +0100)
This patch fixes an error check while using of_irq_to_resource.
of_irq_to_resource returns non-zero interrupt number on success and zero
on error. The driver was using error check is wrong way.

Without this patch the driver will configure interrupt zero if there is
no interrupt specified in the node.

Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@st.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/pinctrl/pinctrl-st.c

index e4c4799b0af8cef329a00faea8107cb8950861bf..bd725b0a43414b77ec068003ac5ddf995824cf21 100644 (file)
@@ -1569,7 +1569,7 @@ static int st_gpiolib_register_bank(struct st_pinctrl *info,
         *      [irqN]----> [gpio-bank (n)]
         */
 
-       if (!of_irq_to_resource(np, 0, &irq_res)) {
+       if (of_irq_to_resource(np, 0, &irq_res)) {
                gpio_irq = irq_res.start;
                irq_set_chained_handler(gpio_irq, st_gpio_irq_handler);
                irq_set_handler_data(gpio_irq, bank);
This page took 0.03566 seconds and 5 git commands to generate.