pata_it821x: fix lost interrupt with atapi devices
authorJeff Norden <jnorden@math.tntech.edu>
Tue, 4 Sep 2007 16:07:20 +0000 (11:07 -0500)
committerJeff Garzik <jeff@garzik.org>
Tue, 11 Sep 2007 01:53:00 +0000 (21:53 -0400)
Fix "lost" interrupt problem when using dma with CD/DVD drives in some
configurations.  This problem can make installing linux from media
impossible for distro's that have switched to libata-only configurations.

The simple fix is to eliminate the use of dma for reading drive status, etc,
by checking the number of bytes to transferred.

This change will only affect the behavior of atapi devices, not disks.
There is more info at http://bugzilla.redhat.com/show_bug.cgi?id=242229
This patch is for 2.6.22.1

Signed-off-by: Jeff Norden <jnorden@math.tntech.edu>
Reviewed-by: Alan Cox <alan@redhat.com>
Signed-off-by: Jeff Garzik <jeff@garzik.org>
drivers/ata/pata_it821x.c

index ed637ae33ece31faecb60076df6106166bd32ff9..5d8b91e70ecd82b41b33b3ab407eeb650599d9ff 100644 (file)
@@ -533,6 +533,10 @@ static int it821x_check_atapi_dma(struct ata_queued_cmd *qc)
        struct ata_port *ap = qc->ap;
        struct it821x_dev *itdev = ap->private_data;
 
+       /* Only use dma for transfers to/from the media. */
+       if (qc->nbytes < 2048)
+               return -EOPNOTSUPP;
+
        /* No ATAPI DMA in smart mode */
        if (itdev->smart)
                return -EOPNOTSUPP;
This page took 0.030209 seconds and 5 git commands to generate.