Record FPSR for SIMD/FP data instructions

I noticed this failure in gdb.reverse/reverse-insn.exp:

FAIL: gdb.reverse/insn-reverse.exp: adv_simd_vect_shift: compare registers on insn 0:fcvtzs     s0, s0, #1

Turns out we're not recording changes to the FPSR.  The SIMD/FP data
instructions may set bits in the FPSR, so it needs to be recorded for
proper reverse operations.

gdb/ChangeLog:

2020-12-16  Luis Machado  <luis.machado@linaro.org>

	* aarch64-tdep.c (aarch64_record_data_proc_simd_fp): Record FPSR.

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 764329d52f6ee138c6d6a8eecd284a5f472b4a03..d621e22e9d93ed7e1fa0f0d9490aea4877555fa1 100644 (file)
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,7 @@
+2020-12-16  Luis Machado  <luis.machado@linaro.org>
+
+       * aarch64-tdep.c (aarch64_record_data_proc_simd_fp): Record FPSR.
+
 2020-12-16  Luis Machado  <luis.machado@linaro.org>
 
        * aarch64-linux-nat.c

diff --git a/gdb/aarch64-tdep.c b/gdb/aarch64-tdep.c
index 40c73be5028995053b92040834acfadfb3e85b8a..5858b64970b103b86d347adb61b2ba59f49bd8b3 100644 (file)
--- a/gdb/aarch64-tdep.c
+++ b/gdb/aarch64-tdep.c
@@ -4470,8 +4470,15 @@ aarch64_record_data_proc_simd_fp (insn_decode_record *aarch64_insn_r)
   if (record_debug)
     debug_printf ("\n");
 
+  /* Record the V/X register.  */
   aarch64_insn_r->reg_rec_count++;
-  gdb_assert (aarch64_insn_r->reg_rec_count == 1);
+
+  /* Some of these instructions may set bits in the FPSR, so record it
+     too.  */
+  record_buf[1] = AARCH64_FPSR_REGNUM;
+  aarch64_insn_r->reg_rec_count++;
+
+  gdb_assert (aarch64_insn_r->reg_rec_count == 2);
   REG_ALLOC (aarch64_insn_r->aarch64_regs, aarch64_insn_r->reg_rec_count,
             record_buf);
   return AARCH64_RECORD_SUCCESS;