perf stat: Add missing aggregation headers for --metric-only CSV
authorAndi Kleen <ak@linux.intel.com>
Tue, 24 May 2016 19:52:39 +0000 (12:52 -0700)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Mon, 6 Jun 2016 20:43:12 +0000 (17:43 -0300)
When in CSV mode --metric-only outputs an header, unlike the other
modes. Previously it did not properly print headers for the aggregation
columns, so the headers were actually shifted against the real values.

Fix this here by outputting the correct headers for CSV.

v2: Indent array.

Signed-off-by: Andi Kleen <ak@linux.intel.com>
Acked-by: Jiri Olsa <jolsa@kernel.org>
Link: http://lkml.kernel.org/r/1464119559-17203-4-git-send-email-andi@firstfloor.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/builtin-stat.c

index a168e726756b678778bcfabb6880b795dc7d7064..dff63733dfb741b7e6f9811529d6c6fc9dc64fb7 100644 (file)
@@ -1316,6 +1316,14 @@ static int aggr_header_lens[] = {
        [AGGR_GLOBAL] = 0,
 };
 
+static const char *aggr_header_csv[] = {
+       [AGGR_CORE]     =       "core,cpus,",
+       [AGGR_SOCKET]   =       "socket,cpus",
+       [AGGR_NONE]     =       "cpu,",
+       [AGGR_THREAD]   =       "comm-pid,",
+       [AGGR_GLOBAL]   =       ""
+};
+
 static void print_metric_headers(const char *prefix, bool no_indent)
 {
        struct perf_stat_output_ctx out;
@@ -1330,6 +1338,12 @@ static void print_metric_headers(const char *prefix, bool no_indent)
        if (!csv_output && !no_indent)
                fprintf(stat_config.output, "%*s",
                        aggr_header_lens[stat_config.aggr_mode], "");
+       if (csv_output) {
+               if (stat_config.interval)
+                       fputs("time,", stat_config.output);
+               fputs(aggr_header_csv[stat_config.aggr_mode],
+                       stat_config.output);
+       }
 
        /* Print metrics headers only */
        evlist__for_each(evsel_list, counter) {
This page took 0.025435 seconds and 5 git commands to generate.