Minor String and Java-doc updates

diff --git a/org.eclipse.linuxtools.lttng2.ui/src/org/eclipse/linuxtools/internal/lttng2/ui/views/control/ControlView.java b/org.eclipse.linuxtools.lttng2.ui/src/org/eclipse/linuxtools/internal/lttng2/ui/views/control/ControlView.java
index cdef5b2e98f29590265d54435ba08f1b07c1b940..1a2aa5411c386dad1624cf3e218972ba3a7bd328 100644 (file)
--- a/org.eclipse.linuxtools.lttng2.ui/src/org/eclipse/linuxtools/internal/lttng2/ui/views/control/ControlView.java
+++ b/org.eclipse.linuxtools.lttng2.ui/src/org/eclipse/linuxtools/internal/lttng2/ui/views/control/ControlView.java
@@ -196,14 +196,12 @@ public class ControlView extends ViewPart implements ITraceControlComponentChang
         myJob.schedule();
     }
     
-//    public ITraceControlComponent getSelection() {
-//        ISelection selection = fTreeViewer.getSelection();
-//        
-//    }
-
     // ------------------------------------------------------------------------
     // Helper methods
     // ------------------------------------------------------------------------
+    /**
+     * Creates the context sensitive menu.
+     */
     private void createContextMenu() {
         // First we create a menu Manager
         final MenuManager menuManager = new MenuManager();

diff --git a/org.eclipse.linuxtools.lttng2.ui/src/org/eclipse/linuxtools/internal/lttng2/ui/views/control/messages.properties b/org.eclipse.linuxtools.lttng2.ui/src/org/eclipse/linuxtools/internal/lttng2/ui/views/control/messages.properties
index 5e1999075a9f0ae7df556883e8477e8341e093c3..a3355f528cdc998f4834ea437e1ffce0f613fa0d 100644 (file)
--- a/org.eclipse.linuxtools.lttng2.ui/src/org/eclipse/linuxtools/internal/lttng2/ui/views/control/messages.properties
+++ b/org.eclipse.linuxtools.lttng2.ui/src/org/eclipse/linuxtools/internal/lttng2/ui/views/control/messages.properties
@@ -78,10 +78,10 @@ TraceControl_FileSubSystemError=File subsystem error in session creation dialog.
 TraceControl_EnableChannelDialogTitle=Enable Channel
 TraceControl_EnableChannelNameLabel=Channel Name
 TraceControl_EnableChannelNameTooltip=The name of the channel to be enabled.
-TraceControl_EnableChannelSubBufferSizeTooltip=The sub-buffers size of the channel.
+TraceControl_EnableChannelSubBufferSizeTooltip=The sub-buffers size of the channel. Needs to be a power of 2 for kernel and ust tracers.
 TraceControl_EnableChannelNbSubBuffersTooltip=The number of sub-buffers of the channel. Needs to be a power of 2 for kernel and ust tracers.
-TraceControl_EnableChannelSwitchTimerTooltip=The switch timer interval in usec.
-TraceControl_EnableChannelReadTimerTooltip=The switch timer interval in usec.
+TraceControl_EnableChannelSwitchTimerTooltip=The Switch subbuffer timer interval in usec (default: 0). Needs to be a power of 2 for kernel and ust tracers.
+TraceControl_EnableChannelReadTimerTooltip=The Read timer interval in usec.
 TraceControl_EnableChannelOutputTypeTooltip=The output type of the channel.
 TraceControl_EnableChannelDiscardModeGroupName=Discard Mode
 TraceControl_EnableChannelDiscardModeLabel=Discard

diff --git a/org.eclipse.linuxtools.lttng2.ui/src/org/eclipse/linuxtools/internal/lttng2/ui/views/control/service/LTTngControlService.java b/org.eclipse.linuxtools.lttng2.ui/src/org/eclipse/linuxtools/internal/lttng2/ui/views/control/service/LTTngControlService.java
index 9746edcd3bf07f43f94e95633540caa36e136e9d..3604d8fa01dcf3662309d81fba532eef98bc2206 100644 (file)
--- a/org.eclipse.linuxtools.lttng2.ui/src/org/eclipse/linuxtools/internal/lttng2/ui/views/control/service/LTTngControlService.java
+++ b/org.eclipse.linuxtools.lttng2.ui/src/org/eclipse/linuxtools/internal/lttng2/ui/views/control/service/LTTngControlService.java
@@ -57,6 +57,9 @@ public class LTTngControlService implements ILttngControlService {
      */
     protected ICommandShell fCommandShell = null;
     
+    /**
+     * The version string.
+     */
     protected String fVersion = "Unknown"; //$NON-NLS-1$
 
     // ------------------------------------------------------------------------
@@ -85,6 +88,10 @@ public class LTTngControlService implements ILttngControlService {
         return fVersion;
     }
     
+    /**
+     * Sets the version of the LTTng 2.0 control service. 
+     * @param version - a version to set
+     */
     public void setVersion(String version) {
         fVersion = version;
     }

diff --git a/org.eclipse.linuxtools.lttng2.ui/src/org/eclipse/linuxtools/internal/lttng2/ui/views/control/service/LTTngControlServiceFactory.java b/org.eclipse.linuxtools.lttng2.ui/src/org/eclipse/linuxtools/internal/lttng2/ui/views/control/service/LTTngControlServiceFactory.java
index b7217b0280cb598c8a96b7dff867c40ebdc43a57..340fdfc2cc60eb016dae3caa5a0894cb7413b828 100644 (file)
--- a/org.eclipse.linuxtools.lttng2.ui/src/org/eclipse/linuxtools/internal/lttng2/ui/views/control/service/LTTngControlServiceFactory.java
+++ b/org.eclipse.linuxtools.lttng2.ui/src/org/eclipse/linuxtools/internal/lttng2/ui/views/control/service/LTTngControlServiceFactory.java
@@ -29,17 +29,26 @@ public class LTTngControlServiceFactory {
     // ------------------------------------------------------------------------
     // Attributes
     // ------------------------------------------------------------------------
+    /**
+     * The singleton instance.
+     */
     private static LTTngControlServiceFactory fInstance = null;
     
     // ------------------------------------------------------------------------
     // Constructor
     // ------------------------------------------------------------------------
+    /**
+     * Constructor
+     */
     private LTTngControlServiceFactory() {
     }
 
     // ------------------------------------------------------------------------
     // Accessors
     // ------------------------------------------------------------------------
+    /**
+     * @return the LTTngControlServiceFactory singleton instance.
+     */
     public static synchronized LTTngControlServiceFactory getInstance() {
         if (fInstance == null) {
             fInstance = new LTTngControlServiceFactory();
@@ -50,6 +59,13 @@ public class LTTngControlServiceFactory {
     // ------------------------------------------------------------------------
     // Factory method
     // ------------------------------------------------------------------------
+    /**
+     * Gets the LTTng Control Service implementation based on the version of the 
+     * remote LTTng Tools.
+     * @param shell - the shell implementation to pass to the service
+     * @return - LTTng Control Service implementation
+     * @throws ExecutionException
+     */
     public ILttngControlService getLttngControlService(ICommandShell shell) throws ExecutionException {
         // get the version
         ICommandResult result = shell.executeCommand(LTTngControlServiceConstants.CONTROL_COMMAND + LTTngControlServiceConstants.COMMAND_VERSION, new NullProgressMonitor());