pinctrl/pinctrl-tegra: remove IS_ERR checking of pmx->pctl
authorDevendra Naga <devendra.aaru@gmail.com>
Mon, 18 Jun 2012 17:44:31 +0000 (23:14 +0530)
committerLinus Walleij <linus.walleij@linaro.org>
Tue, 3 Jul 2012 19:51:08 +0000 (21:51 +0200)
pinctrl_register returns a pointer of struct type struct pinctrl_dev,
if successfully registered to pinctrl subsystem, otherwise returns
NULL, and there wont' be any pointers which are not dereferencible.

They are not type of pointer addresses but are kind of error
codes rather actual addresses, but are a kind of return
codes of functions returning integer types.

return -ENODEV if device registration fails.

Acked-by: Stephen Warren <swarren@wwwdotorg.org>
Signed-off-by: Devendra Naga <devendra.aaru@gmail.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/pinctrl/pinctrl-tegra.c

index 07228b17a370c9e0408b1cba41a554c76040e3dd..ae52e4e5d098cc57d31c9ae8dbd478c05601db1f 100644 (file)
@@ -745,9 +745,9 @@ int __devinit tegra_pinctrl_probe(struct platform_device *pdev,
        }
 
        pmx->pctl = pinctrl_register(&tegra_pinctrl_desc, &pdev->dev, pmx);
-       if (IS_ERR(pmx->pctl)) {
+       if (!pmx->pctl) {
                dev_err(&pdev->dev, "Couldn't register pinctrl driver\n");
-               return PTR_ERR(pmx->pctl);
+               return -ENODEV;
        }
 
        pinctrl_add_gpio_range(pmx->pctl, &tegra_pinctrl_gpio_range);
This page took 0.029939 seconds and 5 git commands to generate.