eeepc-laptop: store_cpufv: return error if set_acpi fails
authorFrans Klaver <fransklaver@gmail.com>
Wed, 17 Sep 2014 21:47:27 +0000 (23:47 +0200)
committerDarren Hart <dvhart@linux.intel.com>
Fri, 19 Sep 2014 16:42:12 +0000 (09:42 -0700)
The result of set_acpi is left unchecked, but it may return errors. If
one occurs, send the error to the caller. There's no reason to lie about
it, if set_acpi fails.

Signed-off-by: Frans Klaver <fransklaver@gmail.com>
Signed-off-by: Darren Hart <dvhart@linux.intel.com>
drivers/platform/x86/eeepc-laptop.c

index 875a43fcaa869d04a6120ad470cfb4254ba7a7eb..3f6c762fb560ac35bc460eb72f3c2bde47bfdb9e 100644 (file)
@@ -388,7 +388,9 @@ static ssize_t cpufv_store(struct device *dev,
                return rv;
        if (value < 0 || value >= c.num)
                return -EINVAL;
-       set_acpi(eeepc, CM_ASL_CPUFV, value);
+       rv = set_acpi(eeepc, CM_ASL_CPUFV, value);
+       if (rv)
+               return rv;
        return count;
 }
 
This page took 0.0251 seconds and 5 git commands to generate.