regmap: fix possible ZERO_SIZE_PTR pointer dereferencing error.
authorXiubo Li <Li.Xiubo@freescale.com>
Sun, 28 Sep 2014 09:09:54 +0000 (17:09 +0800)
committerMark Brown <broonie@kernel.org>
Sun, 28 Sep 2014 10:55:07 +0000 (11:55 +0100)
Since we cannot make sure the 'val_count' will always be none zero
here, and then if it equals to zero, the kmemdup() will return
ZERO_SIZE_PTR, which equals to ((void *)16).

So this patch fix this with just doing the zero check before calling
kmemdup().

Signed-off-by: Xiubo Li <Li.Xiubo@freescale.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
Cc: stable@vger.kernel.org
drivers/base/regmap/regmap.c

index b903aff59af392b7bda6de21400db9fcacccf4b9..e677a1b79f95ad6ee2f562eb93dae0e3f02fa694 100644 (file)
@@ -1659,6 +1659,9 @@ out:
        } else {
                void *wval;
 
+               if (!val_count)
+                       return -EINVAL;
+
                wval = kmemdup(val, val_count * val_bytes, GFP_KERNEL);
                if (!wval) {
                        dev_err(map->dev, "Error in memory allocation\n");
This page took 0.02528 seconds and 5 git commands to generate.