usb: dwc3: core: remove unnecessary dev_warn()
authorFelipe Balbi <balbi@ti.com>
Tue, 7 Jul 2015 18:45:23 +0000 (13:45 -0500)
committerFelipe Balbi <balbi@ti.com>
Wed, 29 Jul 2015 14:59:19 +0000 (09:59 -0500)
When a SoC supports both PHY interfaces but
doesn't define HSPHY in DT/pdata, we will get
an unnecessary dev_warn() which can mislead users
into thinking that they're missing something.

Instead, let's just silently rely on a correct
default. If the HW default is wrong, then HSPHY
is required and USB won't work, this will be
motivation enough for engineers to patch their
way into a working setup.

Reported-by: Murali Karicheri <m-karicheri2@ti.com>
Signed-off-by: Felipe Balbi <balbi@ti.com>
drivers/usb/dwc3/core.c

index ff5773c66b84f22b8ffabe986546d2810d0a9864..064123e445664a5e23bb28ba48cfb1755ec7fb88 100644 (file)
@@ -455,8 +455,6 @@ static int dwc3_phy_setup(struct dwc3 *dwc)
                        reg |= DWC3_GUSB2PHYCFG_ULPI_UTMI;
                        dwc3_writel(dwc->regs, DWC3_GUSB2PHYCFG(0), reg);
                } else {
-                       dev_warn(dwc->dev, "HSPHY Interface not defined\n");
-
                        /* Relying on default value. */
                        if (!(reg & DWC3_GUSB2PHYCFG_ULPI_UTMI))
                                break;
This page took 0.026244 seconds and 5 git commands to generate.