Use unsigned integer constant with left shifts.

This avoids undefined behavior.

gdb/ChangeLog:

	* ada-lang.c (ada_unpack_from_contents): Use unsigned constants with
	left shifts.

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index c9ad9ccb2bfb8f89b0e196897dbdc0c296fa7dbb..5adf9a8f34554d18a7272072ad0a6ce5a206af5f 100644 (file)
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,8 @@
+2016-07-06  John Baldwin  <jhb@FreeBSD.org>
+
+       * ada-lang.c (ada_unpack_from_contents): Use unsigned constants with
+       left shifts.
+
 2016-07-06  John Baldwin  <jhb@FreeBSD.org>
 
        * sh64-tdep.c (sh64_analyze_prologue): Set "uses_fp" when setting

diff --git a/gdb/ada-lang.c b/gdb/ada-lang.c
index b22b7ac78ce9768d448431d68464a4d6f1eb3113..05bfd7b34c74bea5645752ef2eab1f7041c9b08d 100644 (file)
--- a/gdb/ada-lang.c
+++ b/gdb/ada-lang.c
@@ -2525,7 +2525,7 @@ ada_unpack_from_contents (const gdb_byte *src, int bit_offset, int bit_size,
       accumSize += HOST_CHAR_BIT - unusedLS;
       if (accumSize >= HOST_CHAR_BIT)
         {
-          unpacked[unpacked_idx] = accum & ~(~0L << HOST_CHAR_BIT);
+          unpacked[unpacked_idx] = accum & ~(~0UL << HOST_CHAR_BIT);
           accumSize -= HOST_CHAR_BIT;
           accum >>= HOST_CHAR_BIT;
           unpacked_bytes_left -= 1;
@@ -2539,7 +2539,7 @@ ada_unpack_from_contents (const gdb_byte *src, int bit_offset, int bit_size,
   while (unpacked_bytes_left > 0)
     {
       accum |= sign << accumSize;
-      unpacked[unpacked_idx] = accum & ~(~0L << HOST_CHAR_BIT);
+      unpacked[unpacked_idx] = accum & ~(~0UL << HOST_CHAR_BIT);
       accumSize -= HOST_CHAR_BIT;
       if (accumSize < 0)
        accumSize = 0;