Small changes to comply with findBugs plugin suggestions
authorWilliam Bourque <william.bourque@polymtl.ca>
Thu, 6 May 2010 17:34:27 +0000 (17:34 +0000)
committerWilliam Bourque <william.bourque@polymtl.ca>
Thu, 6 May 2010 17:34:27 +0000 (17:34 +0000)
org.eclipse.linuxtools.lttng.jni/src/org/eclipse/linuxtools/lttng/jni/JniMarker.java
org.eclipse.linuxtools.lttng.jni/src/org/eclipse/linuxtools/lttng/jni/JniParser.java
org.eclipse.linuxtools.lttng.jni/src/org/eclipse/linuxtools/lttng/jni/JniTrace.java
org.eclipse.linuxtools.lttng.jni/src/org/eclipse/linuxtools/lttng/jni/common/JniTime.java
org.eclipse.linuxtools.lttng.jni/src/org/eclipse/linuxtools/lttng/jni/factory/JniTraceVersion.java

index 00029641b8b1d6ed285d10345bea3ffde85c7e81..d98fd1989cf719135f4c19aee0e8ce742744361f 100644 (file)
@@ -215,8 +215,8 @@ public abstract class JniMarker extends Jni_C_Common
 
         returnData += "name                    : " + name + "\n";
         returnData += "formatOverview          : " + formatOverview + "\n";
-        returnData += "markerFieldArrayList    : " + markerFieldsArrayList.toArray() + "\n";
-
+        returnData += "markerFieldArrayList    : " + markerFieldsArrayList.hashCode() + " (size : " + markerFieldsArrayList.size() + " )" + "\n";
+        
         return returnData;
     }
     
index 90902c2c8a0358421b2151a1cad8042a1d743a07..adeafd9ff5f2985325d7bf745a3ecb8e846ade08 100644 (file)
@@ -130,14 +130,12 @@ public abstract class JniParser extends Jni_C_Common
                //       HashMap<String, Object> parsedDataMap = (HashMap<String, Object>)markerFieldData.clone();
                // Or even safer, use HashMap constructor to do so : 
         HashMap<String, Object> parsedDataMap = new HashMap<String, Object>(markerFieldData);
-                
-        String              newKey             = null; 
+               
         JniMarkerField      newMarkerField  = null;
         Iterator<String>    iterator        = markerFieldData.keySet().iterator();
         
         while ( iterator.hasNext() ) {
-            newKey = iterator.next();
-            newMarkerField = markerFieldData.get(newKey);
+            newMarkerField = markerFieldData.get(iterator.next());
             // Call the C to parse the data
             ltt_getParsedData(eventToParse.getEventPtr().getLibraryId(), parsedData, eventToParse.getEventPtr().getPointer(), newMarkerField.getMarkerFieldPtr().getPointer());
             // Save the result into the HashMap
@@ -209,7 +207,7 @@ public abstract class JniParser extends Jni_C_Common
      * @param formatToAdd   The format of the raw data
      */
        static private void addShortToParsingFromC(Object contentHolder, short shortToAdd) {
-        ((ParsedObjectContent)contentHolder).setData( new Short(shortToAdd));
+        ((ParsedObjectContent)contentHolder).setData( Short.valueOf(shortToAdd));
     }
 
     /* 
@@ -225,7 +223,7 @@ public abstract class JniParser extends Jni_C_Common
      * @param formatToAdd   The format of the raw data
      */
        static private void addIntegerToParsingFromC(Object contentHolder, int intToAdd) {
-        ((ParsedObjectContent)contentHolder).setData( new Integer(intToAdd));
+        ((ParsedObjectContent)contentHolder).setData( Integer.valueOf(intToAdd));
     }
 
     /* 
@@ -241,7 +239,7 @@ public abstract class JniParser extends Jni_C_Common
      * @param formatToAdd   The format of the raw data
      */
        static private void addLongToParsingFromC(Object contentHolder, long longToAdd) {
-        ((ParsedObjectContent)contentHolder).setData( new Long(longToAdd));
+        ((ParsedObjectContent)contentHolder).setData( Long.valueOf(longToAdd));
     }
 
     /* 
index 7ed77f365afcaabb46dec3a9aa72786ca9d7ef9f..7b3820e14037da6d1545d27735b3b488fae11292 100644 (file)
@@ -179,10 +179,10 @@ public abstract class JniTrace extends Jni_C_Common {
         endTime         = oldTrace.endTime;
 
         tracefilesMap = new HashMap<String, JniTracefile>(oldTrace.tracefilesMap.size());
-        tracefilesMap = oldTrace.tracefilesMap;
+        ltt_feedAllTracefiles(thisTracePtr.getLibraryId(), thisTracePtr.getPointer());
         
         eventsHeap = new PriorityQueue<JniEvent>( oldTrace.eventsHeap.size());
-        eventsHeap = oldTrace.eventsHeap;
+        populateEventHeap();
         
         printLttDebug = oldTrace.printLttDebug;
     }        
@@ -303,10 +303,6 @@ public abstract class JniTrace extends Jni_C_Common {
             
             // Nullify the pointer
             thisTracePtr = new Jni_C_Pointer_And_Library_Id();
-            
-            // Ask the garbage collector to make a little pass here, as we could
-            // be left with 100's of unreferenced objects
-            System.gc();
         }
     }
     
index dc6d2827eb580fe98d160df60b51ba387fedeb88..5f9303da5c8cf4b51a3108b8d4e27cca3e8d2aa4 100644 (file)
@@ -157,6 +157,36 @@ public class JniTime extends Jni_C_Constant implements Comparable<JniTime>
         }
     }
     
+    /**
+     * Overrided equals for JniTime type
+     * 
+     * @param The object we want to compare too
+     * 
+     * @return true if the time is the same, false otherwise.
+     */
+    @Override
+    public boolean equals(Object obj) {
+       boolean returnedValue = false;
+       
+       if ( obj instanceof JniTime ) {
+               if ( ((JniTime)obj).time == this.time ) {
+                       returnedValue = true;
+               }
+       }
+       
+       return returnedValue;
+    }
+    
+    /**
+     * Overridden hash code for JniTime type 
+     * 
+     */
+    @Override
+    public int hashCode() {
+       return this.toString().hashCode();
+    }
+    
+    
     /**
      * toString() method.
      * <u>Intended to debug</u><p>
index 38ad73a3654e35dd9a4d3fb1d616042e75e5bffe..b3727d7c84118cdf0a32bb6fbe179da9ec98d7a7 100644 (file)
@@ -83,7 +83,9 @@ public class JniTraceVersion {
                try {
                        readVersionFromTrace(tracepath);
                }
-               catch(JniTraceVersionException e) { }
+               catch(JniTraceVersionException e) { 
+                       // Yes, we do ignore exception.
+               }
        }
        
        /**
This page took 0.028355 seconds and 5 git commands to generate.