x86/asm/head*.S: Change global labels to local
authorBorislav Petkov <bp@suse.de>
Sat, 16 May 2015 16:17:59 +0000 (18:17 +0200)
committerIngo Molnar <mingo@kernel.org>
Sun, 17 May 2015 05:57:53 +0000 (07:57 +0200)
Make the disassembly look less confusing:

  -- head_64.o.before.asm
  ++ head_64.o.after.asm
   0000000000000120 <early_idt_handler>:
    120: fc                    cld
    121: 83 3c 24 02           cmpl   $0x2,(%rsp)
  - 125: 0f 84 9d 00 00 00     je     1c8 <is_nmi>
  + 125: 0f 84 9d 00 00 00     je     1c8 <early_idt_handler+0xa8>
    12b: 83 3d 00 00 00 00 02  cmpl   $0x2,0x0(%rip)        # 132 <early_idt_handler+0x12>
    132: 74 7e                 je     1b2 <early_idt_handler+0x92>
    134: ff 05 00 00 00 00     incl   0x0(%rip)        # 13a <early_idt_handler+0x1a>
  @@ -1198,9 +1198,7 @@ Disassembly of section .init.text:
    1bf: 5a                    pop    %rdx
    1c0: 59                    pop    %rcx
    1c1: 58                    pop    %rax
  - 1c2: ff 0d 00 00 00 00     decl   0x0(%rip)        # 1c8 <is_nmi>
  -
  -00000000000001c8 <is_nmi>:
  + 1c2: ff 0d 00 00 00 00     decl   0x0(%rip)        # 1c8 <early_idt_handler+0xa8>
    1c8: 48 83 c4 10           add    $0x10,%rsp
    1cc: 48 cf                 iretq

  -- head_32.o.before.asm
  ++ head_32.o.after.asm
   0000016c <early_idt_handler>:
    16c:  fc                      cld
    16d:  83 3c 24 02             cmpl   $0x2,(%esp)
  - 171:  74 73                   je     1e6 <is_nmi>
  + 171:  74 73                   je     1e6 <ex_entry+0xc>
    173:  36 83 3d 00 00 00 00    cmpl   $0x2,%ss:0x0
    17a:  02
    17b:  74 5a                   je     1d7 <hlt_loop>
  @@ -483,8 +483,6 @@ Disassembly of section .init.text:
    1dd:  59                      pop    %ecx
    1de:  58                      pop    %eax
    1df:  36 ff 0d 00 00 00 00    decl   %ss:0x0
  -
  -000001e6 <is_nmi>:
    1e6:  83 c4 08                add    $0x8,%esp
    1e9:  cf                      iret
    1ea:  66 90                   xchg   %ax,%ax

No functionality change.

Signed-off-by: Borislav Petkov <bp@suse.de>
Cc: Andy Lutomirski <luto@amacapital.net>
Cc: Borislav Petkov <bp@alien8.de>
Cc: Brian Gerst <brgerst@gmail.com>
Cc: Denys Vlasenko <dvlasenk@redhat.com>
Cc: H. Peter Anvin <hpa@linux.intel.com>
Cc: H. Peter Anvin <hpa@zytor.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Link: http://lkml.kernel.org/r/1431793079-11153-1-git-send-email-bp@alien8.de
Signed-off-by: Ingo Molnar <mingo@kernel.org>
arch/x86/kernel/head_32.S
arch/x86/kernel/head_64.S

index d031bad9e07eadf3a80bc69a449cd13a44ed8080..02d2572562002962b983c57a01474b05d15eb333 100644 (file)
@@ -547,7 +547,7 @@ ENTRY(early_idt_handler)
        cld
 
        cmpl $2,(%esp)          # X86_TRAP_NMI
-       je is_nmi               # Ignore NMI
+       je .Lis_nmi             # Ignore NMI
 
        cmpl $2,%ss:early_recursion_flag
        je hlt_loop
@@ -600,7 +600,7 @@ ex_entry:
        pop %ecx
        pop %eax
        decl %ss:early_recursion_flag
-is_nmi:
+.Lis_nmi:
        addl $8,%esp            /* drop vector number and error code */
        iret
 ENDPROC(early_idt_handler)
index ae6588b301c248b3c281a1e072802e6764e9ac44..43eafc8afb6959ea4c83c2baf77cebcbd85c29cb 100644 (file)
@@ -344,7 +344,7 @@ ENTRY(early_idt_handler)
        cld
 
        cmpl $2,(%rsp)          # X86_TRAP_NMI
-       je is_nmi               # Ignore NMI
+       je .Lis_nmi             # Ignore NMI
 
        cmpl $2,early_recursion_flag(%rip)
        jz  1f
@@ -409,7 +409,7 @@ ENTRY(early_idt_handler)
        popq %rcx
        popq %rax
        decl early_recursion_flag(%rip)
-is_nmi:
+.Lis_nmi:
        addq $16,%rsp           # drop vector number and error code
        INTERRUPT_RETURN
 ENDPROC(early_idt_handler)
This page took 0.028759 seconds and 5 git commands to generate.