mtip32xx: fix incorrectly setting MTIP_DDF_SEC_LOCK_BIT
authorAsai Thambi SP <asamymuthupa@micron.com>
Mon, 11 May 2015 22:50:50 +0000 (15:50 -0700)
committerJens Axboe <axboe@fb.com>
Tue, 16 Jun 2015 14:24:46 +0000 (08:24 -0600)
Fix incorrectly setting MTIP_DDF_SEC_LOCK_BIT

Signed-off-by: Selvan Mani <smani@micron.com>
Signed-off-by: Asai Thambi S P <asamymuthupa@micron.com>
Signed-off-by: Jens Axboe <axboe@fb.com>
drivers/block/mtip32xx/mtip32xx.c

index 0dd5d7633b708418ec11c309d20ecff255dc37ba..e905c81c0f552804ffdba4ef0f8d42136c1956f6 100644 (file)
@@ -990,15 +990,11 @@ static bool mtip_pause_ncq(struct mtip_port *port,
        reply = port->rxfis + RX_FIS_D2H_REG;
        task_file_data = readl(port->mmio+PORT_TFDATA);
 
-       if (fis->command == ATA_CMD_SEC_ERASE_UNIT)
-               clear_bit(MTIP_DDF_SEC_LOCK_BIT, &port->dd->dd_flag);
-
        if ((task_file_data & 1))
                return false;
 
        if (fis->command == ATA_CMD_SEC_ERASE_PREP) {
                set_bit(MTIP_PF_SE_ACTIVE_BIT, &port->flags);
-               set_bit(MTIP_DDF_SEC_LOCK_BIT, &port->dd->dd_flag);
                port->ic_pause_timer = jiffies;
                return true;
        } else if ((fis->command == ATA_CMD_DOWNLOAD_MICRO) &&
@@ -1010,6 +1006,7 @@ static bool mtip_pause_ncq(struct mtip_port *port,
                ((fis->command == 0xFC) &&
                        (fis->features == 0x27 || fis->features == 0x72 ||
                         fis->features == 0x62 || fis->features == 0x26))) {
+               clear_bit(MTIP_DDF_SEC_LOCK_BIT, &port->dd->dd_flag);
                /* Com reset after secure erase or lowlevel format */
                mtip_restart_port(port);
                return false;
This page took 0.026872 seconds and 5 git commands to generate.