ixgbe: add comment noting recalculation of queues
authorJacob Keller <jacob.e.keller@intel.com>
Thu, 21 Aug 2014 06:16:55 +0000 (06:16 +0000)
committerJeff Kirsher <jeffrey.t.kirsher@intel.com>
Thu, 4 Sep 2014 08:38:33 +0000 (01:38 -0700)
Since we previously called ixgbe_set_num_queues just prior to attempting
to set our interrupt scheme, it may be non obvious why we have to call
it again inside the function. Add a comment which helps make it more
obvious that we are resetting features based on the fact that we do not
have MSI-X enabled, and cannot use the previous settings.

Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
Tested-by: Phil Schmitt <phillip.j.schmitt@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
drivers/net/ethernet/intel/ixgbe/ixgbe_lib.c

index 2d9451e3968624db0b527dd00e9a106adfae16be..ae36fd61a3aa93374e603206dcf77a3f287a2984 100644 (file)
@@ -1086,6 +1086,11 @@ static void ixgbe_set_interrupt_capability(struct ixgbe_adapter *adapter)
                        return;
        }
 
+       /* At this point, we do not have MSI-X capabilities. We need to
+        * reconfigure or disable various features which require MSI-X
+        * capability.
+        */
+
        /* disable DCB if number of TCs exceeds 1 */
        if (netdev_get_num_tc(adapter->netdev) > 1) {
                e_err(probe, "num TCs exceeds number of queues - disabling DCB\n");
@@ -1107,6 +1112,9 @@ static void ixgbe_set_interrupt_capability(struct ixgbe_adapter *adapter)
        /* disable RSS */
        adapter->ring_feature[RING_F_RSS].limit = 1;
 
+       /* recalculate number of queues now that many features have been
+        * changed or disabled.
+        */
        ixgbe_set_num_queues(adapter);
        adapter->num_q_vectors = 1;
 
This page took 0.025276 seconds and 5 git commands to generate.