ASoC: pcm512x: Fix divide by zero issue
authorHoward Mitchell <hm@hmbedded.co.uk>
Fri, 20 Mar 2015 21:13:45 +0000 (21:13 +0000)
committerMark Brown <broonie@kernel.org>
Mon, 23 Mar 2015 06:22:18 +0000 (23:22 -0700)
If den=1 and pllin_rate>20MHz then den and num are adjusted to 0
causing a divide by zero error a few lines further on. Therefore
this patch correctly scales num and den such that
pllin_rate/den < 20MHz as required in the device data sheet.

Signed-off-by: Howard Mitchell <hm@hmbedded.co.uk>
Signed-off-by: Mark Brown <broonie@sirena.org.uk>
Cc: stable@vger.kernel.org
sound/soc/codecs/pcm512x.c

index 194f4c8c56117f66207695d8a17dc22a2c378583..0676ab8be03fa319864a8e86cc715a374758beed 100644 (file)
@@ -576,8 +576,8 @@ static int pcm512x_find_pll_coeff(struct snd_soc_dai *dai,
 
        /* pllin_rate / P (or here, den) cannot be greater than 20 MHz */
        if (pllin_rate / den > 20000000 && num < 8) {
-               num *= 20000000 / (pllin_rate / den);
-               den *= 20000000 / (pllin_rate / den);
+               num *= DIV_ROUND_UP(pllin_rate / den, 20000000);
+               den *= DIV_ROUND_UP(pllin_rate / den, 20000000);
        }
        dev_dbg(dev, "num / den = %lu / %lu\n", num, den);
 
This page took 0.025364 seconds and 5 git commands to generate.