dmaengine: pl330: Initialize pl330 for pl330_prep_dma_memcpy after NULL check of pch
authorManinder Singh <maninder1.s@samsung.com>
Mon, 25 May 2015 19:10:05 +0000 (00:40 +0530)
committerVinod Koul <vinod.koul@intel.com>
Mon, 25 May 2015 17:06:08 +0000 (22:36 +0530)
Currently pch pointer is already dereferenced before NULL check
and thus we are getting below warning:
warn: variable dereferenced before check 'pch'

So initialize struct pl330_dmac *pl330 after NULL check
of dma_pl330_chan *pch.

Signed-off-by: Maninder Singh <maninder1.s@samsung.com>
Reviewed-by: Vaneet Narang <v.narang@samsung.com>
Signed-off-by: Vinod Koul <vinod.koul@intel.com>
drivers/dma/pl330.c

index a7d9d3029b145dfa29babeee33022bc1f7354d52..7e2714478e453fd00e52e70cf30cdf926074de0f 100644 (file)
@@ -2581,12 +2581,14 @@ pl330_prep_dma_memcpy(struct dma_chan *chan, dma_addr_t dst,
 {
        struct dma_pl330_desc *desc;
        struct dma_pl330_chan *pch = to_pchan(chan);
-       struct pl330_dmac *pl330 = pch->dmac;
+       struct pl330_dmac *pl330;
        int burst;
 
        if (unlikely(!pch || !len))
                return NULL;
 
+       pl330 = pch->dmac;
+
        desc = __pl330_prep_dma_memcpy(pch, dst, src, len);
        if (!desc)
                return NULL;
This page took 0.027398 seconds and 5 git commands to generate.