extcon: palmas: explicitly set edev name as node name
authorKishon Vijay Abraham I <kishon@ti.com>
Fri, 28 Mar 2014 06:51:02 +0000 (12:21 +0530)
committerChanwoo Choi <cw00.choi@samsung.com>
Tue, 22 Apr 2014 06:41:10 +0000 (15:41 +0900)
commit ca488 (extcon: of: Remove unnecessary function call by using the
name of device_node) started using node name instead of device name
to get the extcon device. This breaks dwc3-omap since it's not able to
get the extcon device anymore. Fixed it by setting edev name of
palmas to be the same as its node name.

Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
Reported-by: Felipe Balbi <balbi@ti.com>
Reviewed-by: Felipe Balbi <balbi@ti.com>
Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
drivers/extcon/extcon-palmas.c

index ddff2b72f0a898b4e50fe69800dab356e3af9358..51db5bcef72061f3037c61884cb3f60f9f955e97 100644 (file)
@@ -23,6 +23,7 @@
 #include <linux/module.h>
 #include <linux/interrupt.h>
 #include <linux/platform_device.h>
+#include <linux/slab.h>
 #include <linux/err.h>
 #include <linux/mfd/palmas.h>
 #include <linux/of.h>
@@ -188,11 +189,13 @@ static int palmas_usb_probe(struct platform_device *pdev)
 
        palmas_usb->edev.supported_cable = palmas_extcon_cable;
        palmas_usb->edev.dev.parent = palmas_usb->dev;
+       palmas_usb->edev.name = kstrdup(node->name, GFP_KERNEL);
        palmas_usb->edev.mutually_exclusive = mutually_exclusive;
 
        status = extcon_dev_register(&palmas_usb->edev);
        if (status) {
                dev_err(&pdev->dev, "failed to register extcon device\n");
+               kfree(palmas_usb->edev.name);
                return status;
        }
 
@@ -230,6 +233,7 @@ static int palmas_usb_probe(struct platform_device *pdev)
 
 fail_extcon:
        extcon_dev_unregister(&palmas_usb->edev);
+       kfree(palmas_usb->edev.name);
 
        return status;
 }
@@ -239,6 +243,7 @@ static int palmas_usb_remove(struct platform_device *pdev)
        struct palmas_usb *palmas_usb = platform_get_drvdata(pdev);
 
        extcon_dev_unregister(&palmas_usb->edev);
+       kfree(palmas_usb->edev.name);
 
        return 0;
 }
This page took 0.06597 seconds and 5 git commands to generate.