spi: imx: fix loopback mode setup after controller reset
authorAnton Bondarenko <anton.bondarenko.sama@gmail.com>
Tue, 8 Dec 2015 06:43:43 +0000 (07:43 +0100)
committerMark Brown <broonie@kernel.org>
Tue, 15 Dec 2015 22:40:35 +0000 (22:40 +0000)
If controller hold in reset it's not possible to write any
register except CTRL. So all other registers must be updated
only after controller bring out from reset.

Signed-off-by: Anton Bondarenko <anton.bondarenko.sama@gmail.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-imx.c

index 410522fdd4c91e55e902d8add6adaab274e3cdea..3aa33c8c819f478eb66b89438bd1020d192de8bd 100644 (file)
@@ -356,6 +356,9 @@ static int __maybe_unused mx51_ecspi_config(struct spi_imx_data *spi_imx,
        else
                cfg &= ~MX51_ECSPI_CONFIG_SSBPOL(config->cs);
 
+       /* CTRL register always go first to bring out controller from reset */
+       writel(ctrl, spi_imx->base + MX51_ECSPI_CTRL);
+
        reg = readl(spi_imx->base + MX51_ECSPI_TESTREG);
        if (config->mode & SPI_LOOP)
                reg |= MX51_ECSPI_TESTREG_LBC;
@@ -363,7 +366,6 @@ static int __maybe_unused mx51_ecspi_config(struct spi_imx_data *spi_imx,
                reg &= ~MX51_ECSPI_TESTREG_LBC;
        writel(reg, spi_imx->base + MX51_ECSPI_TESTREG);
 
-       writel(ctrl, spi_imx->base + MX51_ECSPI_CTRL);
        writel(cfg, spi_imx->base + MX51_ECSPI_CONFIG);
 
        /*
This page took 0.026876 seconds and 5 git commands to generate.