From: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Date: Wed, 16 Mar 2022 14:48:59 +0000 (-0400)
Subject: Fix: relayd: missing session unlock on error path
X-Git-Url: http://drtracing.org/?a=commitdiff_plain;h=0283afa961253376a5e18de140d29fffd9e89ae3;p=deliverable%2Flttng-tools.git

Fix: relayd: missing session unlock on error path

1475890 Missing unlock May result in deadlock if there is another
attempt to acquire the lock.

In viewer_get_new_streams(relay_connection *): Missing a release of a
lock on a path (CWE-667)

Reported-by: Coverity Scan
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Change-Id: I66de344f5f39ac85bf8db93cf39a07d0c6cf7694
---

diff --git a/src/bin/lttng-relayd/live.cpp b/src/bin/lttng-relayd/live.cpp
index 3efa1beda..5aa899b28 100644
--- a/src/bin/lttng-relayd/live.cpp
+++ b/src/bin/lttng-relayd/live.cpp
@@ -1271,7 +1271,7 @@ int viewer_get_new_streams(struct relay_connection *conn)
 		 * 'ret' to close the connection.
 		 */
 		response.status = htobe32(LTTNG_VIEWER_NEW_STREAMS_ERR);
-		goto send_reply;
+		goto send_reply_unlock;
 	}
 	send_streams = 1;
 	response.status = htobe32(LTTNG_VIEWER_NEW_STREAMS_OK);