From: Linus Torvalds <torvalds@g5.osdl.org>
Date: Wed, 6 Jul 2005 20:05:50 +0000 (-0700)
Subject: ieee1394: fix broken signed char assumption.
X-Git-Url: http://drtracing.org/?a=commitdiff_plain;h=07bbeaf12310263d808b1958f8413b95f98786ea;p=deliverable%2Flinux.git

ieee1394: fix broken signed char assumption.

"ack_code" is assigned (and tested against) negative numbers, but was
declared as "char".  Which only works if "char" is signed - which it
necessarily isn't.

So make that signedness assumption specific.
---

diff --git a/drivers/ieee1394/ieee1394_core.h b/drivers/ieee1394/ieee1394_core.h
index 73bd8efd2b6c..0b31429d0a68 100644
--- a/drivers/ieee1394/ieee1394_core.h
+++ b/drivers/ieee1394/ieee1394_core.h
@@ -38,8 +38,8 @@ struct hpsb_packet {
 
         /* These are core internal. */
         signed char tlabel;
-        char ack_code;
-        char tcode;
+	signed char ack_code;
+	unsigned char tcode;
 
         unsigned expect_response:1;
         unsigned no_waiter:1;