From: Shen Feng Date: Thu, 2 Apr 2009 20:46:06 +0000 (-0400) Subject: Btrfs: free inode struct when btrfs_new_inode fails X-Git-Url: http://drtracing.org/?a=commitdiff_plain;h=09771430f3b46ee27c69daa7ecad82007568e834;p=deliverable%2Flinux.git Btrfs: free inode struct when btrfs_new_inode fails btrfs_new_inode doesn't call iput to free the inode when it fails. Signed-off-by: Shen Feng Signed-off-by: Chris Mason --- diff --git a/fs/btrfs/inode.c b/fs/btrfs/inode.c index 1cff528d5b51..0ecb3fa75dc3 100644 --- a/fs/btrfs/inode.c +++ b/fs/btrfs/inode.c @@ -3481,8 +3481,10 @@ static struct inode *btrfs_new_inode(struct btrfs_trans_handle *trans, if (dir) { ret = btrfs_set_inode_index(dir, index); - if (ret) + if (ret) { + iput(inode); return ERR_PTR(ret); + } } /* * index_cnt is ignored for everything but a dir, @@ -3565,6 +3567,7 @@ fail: if (dir) BTRFS_I(dir)->index_cnt--; btrfs_free_path(path); + iput(inode); return ERR_PTR(ret); }