From: Daeseok Youn Date: Mon, 26 May 2014 10:24:17 +0000 (+0900) Subject: staging: dgap: remove unneeded kfree() in dgap_tty_register_ports() X-Git-Url: http://drtracing.org/?a=commitdiff_plain;h=0ade4a34fd439d62df46937e8f3e584eb0879579;p=deliverable%2Flinux.git staging: dgap: remove unneeded kfree() in dgap_tty_register_ports() When it failed to allocate for printer_ports, serial_ports can be freed in dgap_tty_uninit(). Signed-off-by: Daeseok Youn Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap.c index 60b7d700b07d..06abb2047443 100644 --- a/drivers/staging/dgap/dgap.c +++ b/drivers/staging/dgap/dgap.c @@ -4147,10 +4147,9 @@ static int dgap_tty_register_ports(struct board_t *brd) brd->printer_ports = kcalloc(brd->nasync, sizeof(*brd->printer_ports), GFP_KERNEL); - if (brd->printer_ports == NULL) { - kfree(brd->serial_ports); + if (brd->printer_ports == NULL) return -ENOMEM; - } + for (i = 0; i < brd->nasync; i++) tty_port_init(&brd->printer_ports[i]);